Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an explicitly opt-in, private inventory record API for per-lock administrator references while preserving the ordinary credential-free inventory responses. Raw PIN/card/fingerprint identifiers remain only in the private result in memory and are omitted from repr; downstream consumers must enforce authentication, derive references and discard the source.
Offline management candidates cover single-opcode PIN 03/05 modification and card/fingerprint enrolment/validity/delete payloads, with conservative acknowledgement/progress classifications. There is no BLE dispatcher or newly enabled write path. Authentication, physical confirmation, cancellation and recovery for writes remain unverified on S31; all candidates explicitly report disabled/unvalidated and never authorize retry.
Validation: 364 tests, 97.79% coverage; Ruff/format and strict mypy pass. Existing acquisition, ownership, cancellation, single-send control and inventory regressions retained. Protocol provenance and independently implemented wire facts are documented; original MIT project authorship remains preserved. No live hardware/credential operation was performed.
RC16 development PR based on the exact accepted RC15 SDK commit fda4233. It is not intended for current main's newer transport lineage. Do not merge or publish from this validation PR.
Final SDK candidate remains
73e6c89544dd178cb09de9b88f29f5cf204b2429. Hosted CI 39797805048 attempt2 and CodeQL 39797804910 completed successfully. Hosted pytest:364 passed,97.79% coverage. The stale original Ruff job119889624192 had successful steps but never finalized; one specifically authorized job retry produced successful replacement119912715912. Current PR checks are green, with no source change or empty commit. Immutable archive SHA-256:49ae5d7ccc53c16a96de49089a31ebcbce424d9bbde447263df1b313269cd112. No merge/publication performed.