bugfix - materialize imported decorator const str arguments (#638)#641
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the remaining #638 decorator case where both the decorator factory and
const strargument are imported. Decorator factory lowering now gives nested synthetic callees their own neutral span so span-keyed expression metadata for the full factory call cannot overwrite the callee signature needed by argument materialization.Type of change
docs/RFCs/*)Area(s)
Select the primary areas touched (used for review routing; labels are managed separately):
Key details
const strarguments inincan test, matching the intended InQL/RFC 014 authoring shape.Testing / verification
make test/cargo testmake examples(if relevant)incan fmt --check .(if relevant)Manual verification notes:
cargo test e2e_imported_decorator_factory_const_str_argument_materializes --test integration_tests -- --nocapturecargo test e2e_imported_const_str_materializes_at_test_call_sites --test integration_tests -- --nocapturecargo test user_defined --test codegen_snapshot_testsmake pre-commitDocs impact
If docs updated:
Checklist
Closes #638