feature - implement core scalar functions and operators (#32)#43
Merged
dannymeijer merged 1 commit intoMay 25, 2026
Merged
Conversation
f34fc33 to
b221264
Compare
b221264 to
126f825
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements InQL RFC 015 / issue #32 by moving scalar helpers onto a registry-backed
ColumnExprapplication model, adding the core scalar/operator helper slice, and closing RFC 015 as Implemented. It also removes DataFusion-specific semantics from the function/lowering path by keeping Substrait as the IR boundary and routing Session execution through a backend adapter dispatch layer.Type of change
docs/rfcs/*)Area(s)
Select the primary areas touched (labels sync from checked lines when the triage workflow runs):
Key details
order_by([...])and lower to real Substrait sort fields.ScalarFunctionApplicationExpr, keeps structural column/literal nodes, splits helper modules by logical family, and extends Substrait lowering through registry metadata, built-in Rex shapes, and structural sort-field lowering. Session execution now dispatches through a backend adapter boundary over Substrait plans; DataFusion remains the first adapter.order_bynow use the registry-backed/explicit-sort-key model.Testing / verification
make ci(ormake fmt-check,make build,make test)Manual verification notes:
make fmt-checkmake test-stylemake registry-metadata(passes; still emits the known stale-lock warning)make buildmake build-lockedmake test(108 passed)make smoke-consumergit diff --checkDocs impact
If docs updated:
docs/language/reference/functions/index.md,docs/language/reference/dataset_methods.md,docs/language/reference/execution_context.md,docs/release_notes/v0_1.md,docs/rfcs/015_core_scalar_functions.md,docs/rfcs/014_function_registry.md,docs/rfcs/README.mdChecklist
Closes #32