Conversation
When ntfy is fronted by Cloudflare with Bot Fight Mode on, the default Python-urllib agent gets blocked with HTTP 403. Use the same May-Vehicle-Manager/1.0 UA the webhook sender already uses. Co-authored-by: GrueseGehenRaus <noreply@github.com> Closes #202
- Vehicle.unit_distance / unit_volume / currency don't exist; use the matching User fields (distance_unit, volume_unit, currency). - MaintenanceSchedule.is_due() takes current_odometer; recompute overdue from date and odometer separately. - Reminder.is_due() → is_overdue() (and surface upcoming reminders too). - HA add_fuel now sets user_id on the FuelLog so the insert doesn't fail with a NOT NULL violation. - Drop the xfail markers from tests that documented these bugs. Co-authored-by: Robert von Könemann <robert@vonkoenemann.de> Closes #199 Closes #200
The Cheapest Fuel table reads from FuelPriceHistory. When a fuel log was deleted in an older version, or when the matching row was orphaned for any other reason, the entry kept appearing with no UI to remove it. Add a delete button next to each row on a station's price-history page (only the row's owner can delete it) so users can clear out stale or test data without having to touch the database.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bundled bug-fix release combining four community contributions and a handful of dependency bumps.
Bug Fixes
User-Agent: May-Vehicle-Manager/1.0we already use for webhooks gets them through. Thanks to @GrueseGehenRaus for the diagnosis and patch./api/ha/vehicles*,/api/ha/alertsand/api/ha/fuel/addendpoints referenced fields that don't exist onVehicle(unit_distance,unit_volume,currency) and calledMaintenanceSchedule.is_due()/Reminder.is_due()with the wrong signatures. Those endpoints have been broken since the model refactor. Now they read the units/currency offUser, callis_due(current_odometer)/is_overdue()correctly, andadd_fuelsetsuser_idso the insert no longer hits a NOT NULL violation. Four previously-xfailed tests now pass. Thanks to @vKnmnn for the fix and report.Dependency Updates
pillow>= 12.2.0 (deps: update pillow requirement from >=10.4.0 to >=12.2.0 #193)weasyprint>= 68.1 (deps: update weasyprint requirement from >=62.0 to >=68.1 #190)requests>= 2.34.2 (deps: update requests requirement from >=2.33.1 to >=2.34.2 #191)pytest-cov>= 7.1.0 (deps: update pytest-cov requirement from >=4.1.0 to >=7.1.0 #192)coverage>= 7.14.0 (deps: update coverage requirement from >=7.14.0 to >=7.14.1 #189)Test plan