Conversation
#184 — Reminder recurrence is now a unit (day/week/month/year) plus an integer interval so users can pick things like "every 2 years" for a French MOT. Legacy values (quarterly, biannual) still resolve correctly on read so existing reminders keep working. Form picker is "Every | N | unit" with help text. #175 — EV vehicles were showing £0 in their overview because Vehicle.get_total_cost() only summed fuel + expenses, not charging. Bigger pass alongside the bug fix: - get_total_cost now includes charging cost - New helpers: get_total_charging_kwh, get_average_charging_consumption (kWh per 100 distance, with unit conversion), get_cost_per_kwh - Vehicle view replaces "Total Fuel Cost" with "Total Charging Cost" and "Avg. Consumption" with "Avg. Charging (kWh / 100 km)" on pure EVs; plug-in hybrids see both blocks. Fuel Consumption Trend chart also hidden on pure EVs (matches user feedback "no need for fuel consumption in EVs"). - Dashboard surfaces a "Total Charging Cost" card when there's any charging spend. - Fuel logs page now shows a "Charging History" section beneath the fuel table so EV users see their sessions in the same place. Tests: 6 new for flexible recurrence (interval, legacy values, daily / weekly intervals), 6 new for EV stats (total cost, kWh/100km in km and mi vehicles, cost per kWh, none on empty, fuel-page surfacing). 583 total passing. Bump APP_VERSION to 0.22.4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#184 — Flexible reminder recurrence
Replaces the fixed Monthly / Quarterly / Biannual / Yearly picker with a unit + interval pair, so you can pick things like "every 2 years" for a French MOT or "every 3 months" for a service interval. The form now reads as `Every [N] [unit]`.
Legacy values (`quarterly`, `biannual`) still resolve correctly when reminders created on older versions hit `calculate_next_due_date`, so nothing breaks on upgrade.
#175 — Electric vehicle coverage
The headline bug was that EV vehicles showed £0 in the overview totals because `Vehicle.get_total_cost` only summed fuel + expenses. Fixed plus a broader pass:
Tests