Fix for `smudge-api-oauth2-callback' not updating.#90
Open
cole-brown wants to merge 1 commit intodanielfm:masterfrom
Open
Fix for `smudge-api-oauth2-callback' not updating.#90cole-brown wants to merge 1 commit intodanielfm:masterfrom
cole-brown wants to merge 1 commit intodanielfm:masterfrom
Conversation
Bug: `smudge-api-oauth2-callback' is a defconst, so if the defcustoms it
uses to create its value are not up-to-date /before/ "smudge-api.el" is
loaded, `smudge-api-oauth2-callback' will be an incorrect value.
Fixes:
- Added `smudge-api-oauth2-callback-url' defcustom to complete the set
and make callback fully customizable.
- Removed `smudge-api-oauth2-callback' defconst and replaced it with
the function `smudge-api-oauth2-callback-url'. This will just build
the full callback URL from the defcustoms.
- Updated/added docstrings for what is going on and/or what should
happen with all the `smudge-api-oauth2-...' variables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug:
smudge-api-oauth2-callback' is a defconst, so if the defcustoms it uses to create its value are not up-to-date /before/ "smudge-api.el" is loaded,smudge-api-oauth2-callback' will be an incorrect value.Fixes:
smudge-api-oauth2-callback' defconst and replaced it with the functionsmudge-api-oauth2-callback-url'. This will just build the full callback URL from the defcustoms.