Skip to content

Comments

Image support#65

Open
jkdufair wants to merge 18 commits intodanielfm:masterfrom
jkdufair:feature/image-support
Open

Image support#65
jkdufair wants to merge 18 commits intodanielfm:masterfrom
jkdufair:feature/image-support

Conversation

@jkdufair
Copy link
Contributor

@danielfm I thought this could be fun. Let me know what you think.

image

@jkdufair jkdufair force-pushed the feature/image-support branch from b9b7c8a to 958dc1e Compare February 13, 2021 02:20
@jkdufair
Copy link
Contributor Author

Well this hack doesn't hold up very well to sorting, narrowing, widening etc. I'm gonna close this and mess around some more to find a possibly less hacky way to accomplish this.

@jkdufair
Copy link
Contributor Author

jkdufair commented Apr 3, 2021

Hey @danielfm I got this pretty well working! Works for track and playlist search. I ended up putting the image in the left margin so it didn't jam up spacing of the actual table. Adds maybe 1-2 sec to include images. Not too noticeable. Wanna give it a look?

image

@danielfm
Copy link
Owner

danielfm commented Apr 9, 2021

I´ll try this later. I think we should expose a flag for activating this feature, which defaults to not fetch images.

Do you agree?

@jkdufair
Copy link
Contributor Author

jkdufair commented Apr 9, 2021

I´ll try this later. I think we should expose a flag for activating this feature, which defaults to not fetch images.

Do you agree?

I do agree. There is a config but it defaults to true. Maybe defaulting to false is better. Or maybe default depending on terminal vs gui?

echawk added a commit to echawk/smudge that referenced this pull request Feb 6, 2024
echawk added a commit to echawk/smudge that referenced this pull request Apr 24, 2024
@echawk echawk mentioned this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants