Add lyrics fetching via LRCLIB#111
Merged
danielfm merged 3 commits intodanielfm:masterfrom Feb 3, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds lyrics fetching functionality via the LRCLIB API service, addressing issue #110.
Changes:
- Implements new
smudge-lyrics.elmodule for fetching and displaying lyrics - Adds keyboard binding (
[prefix] l) and menu entries for accessing lyrics - Introduces metadata hook in
smudge-controller.elto notify other components of track changes
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| smudge-lyrics.el | New module implementing LRCLIB API integration, lyrics buffer display, and automatic/manual fetch capabilities |
| smudge.el | Integrates lyrics module with keyboard bindings and menu entries |
| smudge-controller.el | Adds metadata update hook to enable lyrics auto-fetching on track changes |
| README.md | Documents new lyrics feature, keybinding, and configuration options |
Comments suppressed due to low confidence (1)
README.md:1
- Corrected spelling of 'isn't' to 'isn't' (removed double 'is').
# Smudge
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
danielfm
reviewed
Feb 3, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Owner
|
Worked nicely here as well. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR to implement #110.