Skip to content

Comments

Add lyrics fetching via LRCLIB#111

Merged
danielfm merged 3 commits intodanielfm:masterfrom
lgmoneda:lyrics
Feb 3, 2026
Merged

Add lyrics fetching via LRCLIB#111
danielfm merged 3 commits intodanielfm:masterfrom
lgmoneda:lyrics

Conversation

@lgmoneda
Copy link
Contributor

@lgmoneda lgmoneda commented Feb 2, 2026

PR to implement #110.

@danielfm danielfm requested a review from Copilot February 2, 2026 21:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds lyrics fetching functionality via the LRCLIB API service, addressing issue #110.

Changes:

  • Implements new smudge-lyrics.el module for fetching and displaying lyrics
  • Adds keyboard binding ([prefix] l) and menu entries for accessing lyrics
  • Introduces metadata hook in smudge-controller.el to notify other components of track changes

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
smudge-lyrics.el New module implementing LRCLIB API integration, lyrics buffer display, and automatic/manual fetch capabilities
smudge.el Integrates lyrics module with keyboard bindings and menu entries
smudge-controller.el Adds metadata update hook to enable lyrics auto-fetching on track changes
README.md Documents new lyrics feature, keybinding, and configuration options
Comments suppressed due to low confidence (1)

README.md:1

  • Corrected spelling of 'isn't' to 'isn't' (removed double 'is').
# Smudge

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

danielfm and others added 2 commits February 2, 2026 21:08
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@danielfm danielfm self-assigned this Feb 3, 2026
@danielfm
Copy link
Owner

danielfm commented Feb 3, 2026

Worked nicely here as well. Thanks!

@danielfm danielfm merged commit c90db83 into danielfm:master Feb 3, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants