Repository navigation
fix: build separate Chromium and Firefox packages - #22
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edge Add-ons rejected
spectral-0.1.0.zip: The background.scripts field cannot be used with manifest version 3. The single manifest declared bothservice_worker(Chromium) andscripts(Firefox, which has no background service workers).public/manifest.json→src/manifest.json, without abackgroundkey.scripts/manifest.tsis a small Vite plugin that emitsmanifest.jsonwith the bundle: Chromium getsbackground.service_workerand nobrowser_specific_settings, Firefox getsbackground.scripts(unit-tested inscripts/manifest.test.ts).npm run build/npm run devnow writedist/(Chrome, Edge, Safari, e2e) anddist-firefox/; thefirefox:*scripts point atdist-firefox/.e2e/tsconfig.jsonallows.tsimports, which Node needs to runscripts/build.ts.spectral-chromiumandspectral-firefoxartifacts; the Release workflow attachesspectral-<version>-chromium.zipandspectral-<version>-firefox.zip.Checks run locally:
npm run check(49 tests passed),npm run build(both outputs, nine files each),npm run firefox:lintondist-firefox/(0 errors, 0 warnings: the old expected warning is gone), watch mode writes both manifests.npm run test:e2ecould not run locally (Playwright's Chromium is missinglibnspr4.soin this WSL), so it relies on CI. The Safari workflow now converts aservice_worker-only build and has not been run with this change.