Repository navigation
feat(report): the month as a waterfall, with one line less on top - #75
Merged
Merged
Conversation
The month's stacked bar is gone. The rows under "Where your gross pay goes" now step from the gross pay, through what is added to it (an expense refund, a contribution relief, a tax bonus), down each deduction to the net pay; each row has a span on a track that starts where the one before it ended. The gross pay's items open from its row, and the items some payroll software leaves out of the gross are listed under what is added rather than among them. A rounding under a euro with no item of its own makes no step. The list of items left out of the gross moves to the payslip package, so that the checks and the report share it.
The line with the month and whether the numbers add up, and the "Net pay" label under it, become one line: "Net pay for October 2026", with the arrows to the month before and after. Whether the numbers add up moves beside the gross pay under the amount.
danielededo
force-pushed
the
feat/waterfall
branch
from
October 23, 2026 21:03
879fd80 to
99bcd32
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two changes to the month, in two commits.
1. "Where your gross pay goes" as a waterfall
This section was a stacked bar with a legend below it. It is now a waterfall: a row per step, from the gross pay down to the net pay. Each row has a span on its own track, which starts where the one before it ended.
The rows
A rounding under a euro with no item of its own makes no step.
Code
extract/validate.gotopayslip.OutsideGross, so that the checks and the report share it.report.PartlosesColorand gainsFrom/Width, the span on the track.html/templateblocks avar(...)written in astyleattribute.2. One line less at the top of the month
Before, the month opened with three short lines: "October 2026 ✓ the numbers add up" with the arrows, then "Net pay", then the amount. Now it opens with two:
The heading text is built in Go (
Month.NetOf), because the template's text map is already formatted.Type of change
Checklist
CHANGELOG.mdupdated underUnreleasedfor user-visible changesNotes for the reviewer
Tests
TestAddedToGrosscovers:Checks run locally on top of main after #74 (all pass)
go test -race ./...;I also looked at it on a phone-sized screen (light and dark) and on desktop.