Repository navigation
feat(web): files in a sheet of their own, not on the page - #70
Merged
Merged
Conversation
The page no longer lists the files read. It says only how many need a look, if any, in one line under the buttons; the files are in a sheet opened from that line or from "Files read" under the report, full screen on a phone and at the side of a wider screen. The sheet lists what needs a look first, with the files whose payslips were all read before as one line, then the payslips read by month, the latest first and the first six until asked for all, with the person when there are several and the file's name in small. Each offers its anonymized copy, which now opens in the sheet. The back button and Escape close it. The core tells, for each document, its latest month and whose payslips they are.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With many payslips, the list of files grew long on the page, and it showed every file whenever one needed a look. Now the page lists no file at all.
On the page
The sheet
<dialog>: full screen on a phone, a 480 px panel at the side of a wider screen. ✕, Escape and the browser's back button close it; it pushes a history entry so that back works.Core
analyzenow also returns, per document,latest(year×100+month, for sorting) andpeople.report.PersonLabelis exported for this.Type of change
Checklist
CHANGELOG.mdupdated underUnreleasedfor user-visible changesNotes for the reviewer
e2e tests
statuses()now reads every file's line in the sheet, in the order the files were picked, throughdata-i/data-note. The existing assertions on statuses are unchanged.Local checks
go test -race, piiscan, the web unit tests and the 13 e2e tests in Chromium all pass. WebKit runs in CI.