Skip to content

feat(web): files in a sheet of their own, not on the page - #70

Merged
danielededo merged 1 commit into
mainfrom
feat/files-sheet
Oct 20, 2026
Merged

danielededo merged 1 commit into
mainfrom
feat/files-sheet

Conversation

@danielededo

@danielededo danielededo commented Oct 20, 2026 •

Copy link
Copy Markdown
Owner

Summary

With many payslips, the list of files grew long on the page, and it showed every file whenever one needed a look. Now the page lists no file at all.

On the page

  • One line under the buttons says how many files need a look, for example "1 file to look at ›", and only if any do.
  • Under the report, "Files read (12) · Something read badly?" opens the files.

The sheet

  • A <dialog>: full screen on a phone, a 480 px panel at the side of a wider screen. ✕, Escape and the browser's back button close it; it pushes a history entry so that back works.
  • To look at: files with a problem, each with its reason. Files whose every payslip was read before collapse into one line, such as "2 files already read, ignored", which opens to list them.
  • Payslips read: by month, the latest first. The month is the main text, and the file's name sits small below it, after the person when there are several. The first six show, with "Show all (n)" for the rest.
  • Anonymized copy: each row has a link to it. The copy now opens inside the sheet, with "‹ Back to the files".

Core

  • analyze now also returns, per document, latest (year×100+month, for sorting) and people.
  • report.PersonLabel is exported for this.

Type of change

  • New feature (non-breaking)

Checklist

  • Commits follow the commit convention
  • Tests added or updated for the change
  • All tests and linters pass locally
  • Documentation updated (README, docs/, comments) where behavior changed
  • CHANGELOG.md updated under Unreleased for user-visible changes

Notes for the reviewer

e2e tests

  • statuses() now reads every file's line in the sheet, in the order the files were picked, through data-i/data-note. The existing assertions on statuses are unchanged.
  • New assertions cover:
    • the count on the page;
    • the repeated files grouped into one line;
    • the anonymized copy opened from the sheet;
    • closing the sheet with the back button.
  • The agreement test expects the two new per-document fields.

Local checks

The page no longer lists the files read. It says only how many need a
look, if any, in one line under the buttons; the files are in a sheet
opened from that line or from "Files read" under the report, full screen
on a phone and at the side of a wider screen.

The sheet lists what needs a look first, with the files whose payslips
were all read before as one line, then the payslips read by month, the
latest first and the first six until asked for all, with the person when
there are several and the file's name in small. Each offers its
anonymized copy, which now opens in the sheet. The back button and
Escape close it.

The core tells, for each document, its latest month and whose payslips
they are.
@danielededo
danielededo merged commit 528993f into main Oct 20, 2026
3 checks passed
@danielededo
danielededo deleted the feat/files-sheet branch October 20, 2026 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant