Repository navigation
feat(report): four tabs, one question each, and a swipe that follows the finger - #69
Closed
danielededo wants to merge 1 commit into
Closed
danielededo wants to merge 1 commit into
danielededo wants to merge 1 commit into
Conversation
…the finger The month answers how much you got and why: what changed sits right under the net pay, the gross pay's items open from a row above where it goes, and what is set aside, holidays and leave, and other information are rows that open, the first two leading to the new Accrued tab. Over time keeps the charts and the year by year totals, without the pension fund rows and the net of every 100 € of gross, which the month already says. Accrued gathers what builds up for you: holidays and leave, the pension fund with what counted as deductible each year, and the TFR. The notes under the charts are shorter. A swipe between tabs now follows the finger, goes on a flick or past a quarter of the screen and springs back otherwise. It starts over charts unless their amounts are shown, and over a row that scrolls sideways once that row can scroll no further; a tap that ends a swipe no longer selects a column.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The report had grown long. This PR reorganizes it into four tabs, each answering one question, and makes swiping between them smooth.
The month: how much did I get, and why?
Over time: how is my pay going?
Accrued (new): what am I building up?
fundYears).Notes: the notes under the charts and tables are one line each.
Swipe
touch-action: pan-y pinch-zoomon panels hands horizontal moves to the page, while vertical scrolling and zoom stay native.Type of change
Checklist
CHANGELOG.mdupdated underUnreleasedfor user-visible changesNotes for the reviewer
Tests
Manual checks
Local checks
go test -race, piiscan, the web unit tests and the 13 e2e tests in Chromium all pass.