Repository navigation
fix(report): one story for the pension fund and the month's summary - #65
Merged
Merged
Conversation
Set aside for you now includes your own pension fund contribution withheld from the pay, so that its total matches what goes to the fund, and says which part was withheld; other deductions say when they are mostly the pension fund. The line about the fund stays only when part of the TFR is kept by the employer, under set aside, where it belongs. The summary's reasons can be the taxes or contributions of boxes printed apart from the items, so a year-end adjustment is named as what lowered the net; its tax rate change is then not repeated, nor the general note on year-end adjustments when the month explains its own.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes found while reviewing the report's month view against real payslips.
Pension fund
Month summary
Type of change
Checklist
CHANGELOG.mdupdated underUnreleasedfor user-visible changesNotes for the reviewer
Box amounts in the summary
effects()counts a taxes or contributions box only when it adds to the items: either the total deductions were checked with it, or the table has no item of its kind. This matches howdeductions_sumcombines them.Tests and checks
TestPensionFundInContributionsnow covers the new set-aside total, the withheld note and the label.go test -race, piiscan, the web unit tests and the 12 e2e tests in Chromium all pass.