Skip to content

fix(report): one story for the pension fund and the month's summary - #65

Merged
danielededo merged 1 commit into
mainfrom
fix/month-story
Oct 20, 2026
Merged

danielededo merged 1 commit into
mainfrom
fix/month-story

Conversation

@danielededo

@danielededo danielededo commented Oct 20, 2026 •

Copy link
Copy Markdown
Owner

Summary

Fixes found while reviewing the report's month view against real payslips.

Pension fund

  • Set aside for you: now includes your own fund contribution withheld from the pay. The total matches what goes to the fund, for example 1.074,49 € instead of 290,93 € next to a line saying 1.074,49 €.
  • A note says which part was withheld and that it also appears among the other deductions.
  • When most of "Other deductions" is your fund contribution, it is labeled "Other deductions, mostly the pension fund".
  • Fund line: the separate line about the fund appears only when it says something new, that is when part of the TFR stays with the employer. It sits under "Set aside for you"; after fix(report): explain a year-end or end-of-employment adjustment #64 it had ended up under "Other information".

Month summary

  • Driver: the taxes or contributions printed in summary boxes, rather than as items, can now be what the summary names. A year-end adjustment month now reads "you receive 907,43 € less, mostly because of Taxes (-939,23 €)". Before, it gave no reason.
  • Repeated tax rate: when taxes are named, the "Taxes are x% of gross" change is not repeated below.
  • Repeated note: a month that explains its own adjustment no longer repeats the general note about December and the 730.

Type of change

  • Bug fix (non-breaking)

Checklist

  • Commits follow the commit convention
  • Tests added or updated for the change
  • All tests and linters pass locally
  • Documentation updated (README, docs/, comments) where behavior changed
  • CHANGELOG.md updated under Unreleased for user-visible changes

Notes for the reviewer

Box amounts in the summary

  • effects() counts a taxes or contributions box only when it adds to the items: either the total deductions were checked with it, or the table has no item of its kind. This matches how deductions_sum combines them.

Tests and checks

  • TestPensionFundInContributions now covers the new set-aside total, the withheld note and the label.
  • It also covers a TFR kept by the employer, which brings back the fund line.
  • Locally: gofmt, vet, staticcheck, go test -race, piiscan, the web unit tests and the 12 e2e tests in Chromium all pass.

Set aside for you now includes your own pension fund contribution
withheld from the pay, so that its total matches what goes to the fund,
and says which part was withheld; other deductions say when they are
mostly the pension fund. The line about the fund stays only when part of
the TFR is kept by the employer, under set aside, where it belongs.

The summary's reasons can be the taxes or contributions of boxes printed
apart from the items, so a year-end adjustment is named as what lowered
the net; its tax rate change is then not repeated, nor the general note
on year-end adjustments when the month explains its own.
@danielededo
danielededo merged commit 60fa099 into main Oct 20, 2026
3 checks passed
@danielededo
danielededo deleted the fix/month-story branch October 20, 2026 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant