Repository navigation
refactor(storage_format): split base Node class into two distinctclasses for leaf and internal nodes and updated the usage in serializer.py and tests. - #340
Merged
Conversation
classes for leaf and internal nodes and updated the usage in serializer.py and tests.
mattsva
approved these changes
Oct 12, 2026
mattsva
left a comment
Collaborator
There was a problem hiding this comment.
lgtm
@mohammedFawzy0111 please tell @sowashieristjaschoninteressant in PR #338 what needs to be changed there to make it work.
Collaborator
|
Merging this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
refactor the Node class to to seprate calsses for LeafNode and InternalNode instead of depending on a boolean.
Closes #339
Type of Change
Key Changes
Validation
Checklist
uv run ruff check .anduv run ruff format --check ., or this PR does not change Python.