Prevent exception on restore in multiplexer env#17
Open
weierophinney wants to merge 1 commit intodanielcopper:mainfrom
Open
Prevent exception on restore in multiplexer env#17weierophinney wants to merge 1 commit intodanielcopper:mainfrom
weierophinney wants to merge 1 commit intodanielcopper:mainfrom
Conversation
…tiplexer `pane:get_foreground_process_name()` is documented as returning `nil` when run in the multiplexer of via SSH. This means that the `foreground_process` variable may be `nil` when the conditional that is searching it as if it were a string will instead raise an exception as it cannot call that operation on `nil`. To resolve the error, this patch checks for a non-nil value at the start of the conditional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore can fail when called in a multiplexer environment.
pane:get_foreground_process_name()is documented as returningnilwhen run in the multiplexer of via SSH. This means that theforeground_processvariable may benilwhen the conditional that is searching it as if it were a string will instead raise an exception as it cannot call that operation onnil.To resolve the error, this patch checks for a non-nil value at the start of the conditional.
Fixes #16