Repository navigation
feat: apply diff review design to homepage and public pages - #3
Open
daniel-tsx wants to merge 1 commit into
Open
daniel-tsx wants to merge 1 commit into
daniel-tsx wants to merge 1 commit into
Conversation
Rebuild the homepage as a pull-request style review: a diff hero, live stats as CI-style checks, a files-changed sidebar, review comments on example releases, FAQ threads and a merge box with the digest form. Session redirect, JSON-LD and FAQ schema are unchanged. Add shared public building blocks (SiteHeader, SiteFooter, PageIntro, FileCard, DiffLine, ReviewComment, MergeBox, Checks, StatGrid, CenteredShell) and move stacks, release, upgrade planner, skills, status, legal, sign-in, 404, error and unsubscribe pages onto them. Auth, vote, digest and unsubscribe logic is untouched; those files change markup and copy only. Remove the unused StackPulseHero, document the new language in DESIGN_SYSTEM.md and mock the new imports in the release page test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Replace the homepage with the "diff review" design (chosen from six design-lab explorations) and apply the same language to every public page, so StackPulse reads like a pull request: file cards,
+/-lines, review comments on risky releases and a merge-box call to action. The design lab itself was temporary and is not part of this branch.Review guide
src/app/page.tsx: rebuilt homepage. The session redirect,instant = false, JSON-LD and FAQ schema are carried over unchanged; live stats (getLandingStats) now render as CI-style checks, with a no-numbers fallback when stats are unavailable. Release rows in the hero review are illustrative and labelledexample.src/components/review/review-ui.tsxandsrc/components/site/*: the new shared building blocks (PageIntro,FileCard,DiffLine,ReviewComment,MergeBox,Checks,StatGrid,CardNote,CenteredShell,SiteHeader,SiteFooter). File-card headers stick under the site header viaoverflow-clip.src/app/(auth)/sign-in/page.tsx(sign-in handler,safeReturnPathand the error state are unchanged),src/app/digest/unsubscribe/page.tsx(formaction={unsubscribeFromDigest}and hiddentokeninput unchanged, only re-indented) andsrc/components/landing/digest-signup-form.tsx(submit, honeypot andsubscribeToDigestcall unchanged; adds a labelhtmlFor,aria-describedby,role="status"and aframedprop).globals.cssadds two hero keyframes and changes the legalh2prefix.docs/DESIGN_SYSTEM.mddocuments the new language.overflow: clip(Safari 16+). The signed-in app (dashboard, onboarding, settings) intentionally keeps the old window-chrome style, so public and app pages now differ.tests/release-votes.test.mjsgains three module mocks for the release page's new imports; no assertions changed.src/components/stack-pulse-hero.tsx(no remaining users).motionstays, sinceui/animated-beam.tsxstill imports it.Task size
T2 by file area (the review-signals guard flags
sign-in/page.tsxanddigest/unsubscribe/page.tsx). The change itself is UI only. No AGENTS.md invariant is affected: auth stays GitHub-only withsafeReturnPath, the digest and unsubscribe server actions are unchanged, and there is no schema, cron or provider change.Checks
pnpm lintpnpm typechecktsc --noEmitpnpm testpnpm test:votesgit diff --checknode scripts/check-migration-history.mjs origin/main HEADnode scripts/check-pr-review-signals.mjs origin/main HEADpnpm dev+ agent-browserpnpm build.envdatabase; no isolated database was availableVOTE_TEST_DATABASE_URL,SKILL_TEST_*)Unverified boundaries
pnpm buildnot run)..env(read-only page views: no form submits, votes or sign-in). There was no isolated data.Review
codex-review): NOT RUN yet. AGENTS.md requires one for T2-area files before merge./security-review: NOT RUN. No auth behavior changed, but the sign-in page file is in an auth area.Docs and temporary files
docs/DESIGN_SYSTEM.md(visual identity, layout patterns, motion, shared components, copy voice, page templates, checklist)..tmp/diff-review-redesign/(git-ignored) keeps the verification screenshots, scripts and this description until merge or rejection.🤖 Generated with Claude Code