Skip to content

chore(agents): apply workflow test-run fixes and vendor React skill - #7

Merged
daniel-tsx merged 1 commit into
mainfrom
chore/workflow-test-fixes
Oct 24, 2026
Merged

daniel-tsx merged 1 commit into
mainfrom
chore/workflow-test-fixes

Conversation

@daniel-tsx

Copy link
Copy Markdown
Owner

Fixes from the T0/T1/T2 test runs (A, A', B, C, D):

  • Task size: the highest matching row wins; Docker only when database, queue or transaction behavior changes; decision records read when their invariants could be affected (C, D); Dashboard row reads the payment-flow doc only for behavior changes (B); CLAUDE.md wording (D)
  • Worktrees: branch from fetched origin/main with --no-track; new slug when one exists; slug does not repeat the type; worktree copy of AGENTS.md wins; checks and git status run in the worktree (A, A', B)
  • Verification: docs-only row; browser checks via any host browser tool
  • Review: no author claims in the reviewer package; design reviews via codex exec -s read-only or a subagent; list decisions instead of grilling when one final approval is requested (C, D)
  • Migrations: number after rebase; check-migration-history rejects an appended journal entry whose when is not newer (drizzle skips it)
  • Docker runner moves spec byproducts from the .tmp/ root into its run directory, deletes it after a pass and keeps it after a failure; runner unit tests no longer write to the real .tmp/
  • .gitattributes normalizes text to LF; .claude/worktrees/ ignored
  • Vendor vercel-react-best-practices from vercel-labs/agent-skills @063bee94 for both hosts; compiled AGENTS.md omitted (hosts may auto-load nested AGENTS.md) and a LICENSE note added (upstream declares MIT but ships no LICENSE file)

Claude-Session: https://claude.ai/code/session_015v69WpyGF25M7eMDxFThpE

What and why

Review guide

Task size

Checks

Result Command Scope / notes

Unverified boundaries

Review

Docs and temporary files

Fixes from the T0/T1/T2 test runs (A, A', B, C, D):

- Task size: the highest matching row wins; Docker only when database,
  queue or transaction behavior changes; decision records read when
  their invariants could be affected (C, D); Dashboard row reads the
  payment-flow doc only for behavior changes (B); CLAUDE.md wording (D)
- Worktrees: branch from fetched origin/main with --no-track; new slug
  when one exists; slug does not repeat the type; worktree copy of
  AGENTS.md wins; checks and git status run in the worktree (A, A', B)
- Verification: docs-only row; browser checks via any host browser tool
- Review: no author claims in the reviewer package; design reviews via
  codex exec -s read-only or a subagent; list decisions instead of
  grilling when one final approval is requested (C, D)
- Migrations: number after rebase; check-migration-history rejects an
  appended journal entry whose `when` is not newer (drizzle skips it)
- Docker runner moves spec byproducts from the .tmp/ root into its run
  directory, deletes it after a pass and keeps it after a failure;
  runner unit tests no longer write to the real .tmp/
- .gitattributes normalizes text to LF; .claude/worktrees/ ignored
- Vendor vercel-react-best-practices from vercel-labs/agent-skills
  @063bee94 for both hosts; compiled AGENTS.md omitted (hosts may
  auto-load nested AGENTS.md) and a LICENSE note added (upstream
  declares MIT but ships no LICENSE file)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015v69WpyGF25M7eMDxFThpE
@github-actions github-actions Bot added the guard-change Changes CI or a guard script: independent review label Oct 24, 2026
@daniel-tsx
daniel-tsx merged commit ccc8fb7 into main Oct 24, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

guard-change Changes CI or a guard script: independent review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant