Repository navigation
fix(ci): tighten review signals and align workflow artifacts - #6
Merged
Merged
Conversation
- T2 detection: shared idempotency service and its payload hash, and runtime app modules (wiring a dormant writer is an activation). CI and guard scripts get a separate guard-change label: independent review without T2 financial reading. - Skip guard: env-gated suites must match the exact RUN_* === '1' ? describe : describe.skip alias; any other new skip needs a non-empty "// allow-skip: <reason>" comment and is always listed for human approval. Mentioning process.env or allow-skip no longer bypasses the guard. - Non-blocking signals for net assertion removal and weak matchers. - engineering-workflow artifact set made explicit (state.json, plan.md, immutable reviewer reports, verification.json, final-checks.json, at most one handoff.md); recorded files change only via the state helper. - docs/verification.md documents the job-scoped issues/pull-requests write permissions of Review signals and why they are needed. The "new skipped test fails unless env-gated or explicitly allowed" case is replaced by three narrower tests (env gate, allowed-and-listed, bypass attempts). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015v69WpyGF25M7eMDxFThpE
The guard-change description string lost its closing quote, so the "Sync review labels" step failed with "unexpected EOF". All workflow run blocks were checked with bash -n, and the label step was exercised with a stub gh under bash -eo pipefail for t2/guard/none combinations. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015v69WpyGF25M7eMDxFThpE
github-actions
Bot
added
the
guard-change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "new skipped test fails unless env-gated or explicitly allowed" case is replaced by three narrower tests (env gate, allowed-and-listed, bypass attempts).
Claude-Session: https://claude.ai/code/session_015v69WpyGF25M7eMDxFThpE
What and why
Review guide
Task size
Checks
Unverified boundaries
Review
Docs and temporary files