Repository navigation
docs(agents): add T2 plan review and engineering-workflow suggestion - #15
Merged
Merged
Conversation
- T2 changes to schema, money semantics, locking or idempotency get a plan of at most 200 lines, a codex-review design review and the user's approval before implementation, so design errors surface before code is written. - For T2 tasks spanning several checkpoints, combining a migration with runtime changes, or likely to be interrupted, the agent recommends engineering-workflow in one line and asks; it never starts it alone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015v69WpyGF25M7eMDxFThpE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Close the one gap in the normal T2 flow: design errors were only caught after code existed, because
codex-reviewreviewed code, not plans. T2 changes to schema, money semantics, locking or idempotency now get a plan of at most 200 lines, acodex-reviewdesign review and the user's approval before implementation. Large T2 tasks (several checkpoints, a migration plus runtime changes, or likely interruption) get a one-line recommendation to useengineering-workflow, and the agent asks first instead of starting it.Review guide
AGENTS.md(the only change). Check that the trigger conditions are narrow enough that ordinary T2 tasks are not asked every time.Task size
T0: rule wording in
AGENTS.md; no code, no T2 paths (Review signals: no T2-area files).Checks
git diff --checknode scripts/check-engineering-workflow.mjsnode scripts/sync-agent-skills.mjs --checknode scripts/check-pr-review-signals.mjs origin/main HEADUnverified boundaries
Agent behavior under the new rule is untested until the next T2 task that changes schema, money semantics, locking or idempotency.
Review
T0: author re-read the diff.
Docs and temporary files
AGENTS.mdis the owning document. Local.tmp/t2-plan-review/(worktree and transfer bundle) stays until merge.Generated by Claude Code