Repository navigation
chore(agents): add codex-review and ship-pr skills, vendor frontend-design - #13
Merged
Merged
Conversation
…esign - codex-review (local): package a factual brief and the reviewed SHA, run Codex read-only against origin/main (designs too), fall back to a fresh read-only subagent when Codex cannot run, triage each finding (accept/reject with evidence/human decision), max two correction rounds - ship-pr (local): rebase onto origin/main, migration and review-signal guards, pre-PR checks, review prerequisites, PR description from the template, push and gh pr create only after explicit authorization, worktree cleanup after merge - Vendor frontend-design from anthropics/skills@dbd4588f (Apache-2.0, LICENSE.txt) for both hosts; sync accepts LICENSE or LICENSE.txt - Remove grill-me (grilling covers it) and its Codex adapter in sync - AGENTS.md: Review uses codex-review (fixes the stale `--base main`), /security-review for auth, tenancy, billing/payments or secrets; ship-pr for PRs; frontend-design for visual direction - check-engineering-workflow also verifies the two local skills mirror Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015v69WpyGF25M7eMDxFThpE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Encode the two procedures every task repeats as local skills, and add a design skill for the UI revamp.
codex-reviewruns the T2 cross-model review (Codex read-only againstorigin/main, fallback subagent, triage).ship-prprepares and opens PRs only after explicit authorization.frontend-design(anthropics/skills) guides visual direction.grill-meis removed becausegrillingcovers it. AGENTS.md now routes to these skills, fixes the stalecodex review --base main(localmaincan lag in worktrees) and adds/security-reviewfor auth, tenancy, billing/payments or secrets.Review guide
.agents/skills/codex-review/SKILL.mdand.agents/skills/ship-pr/SKILL.md(the.claudecopies are identical and CI-checked). Check that the procedures match AGENTS.md and never push without authorization.scripts/sync-agent-skills.mjs(grill-me adapter removed, LICENSE or LICENSE.txt accepted) andscripts/check-engineering-workflow.mjs(mirror check for the two local skills).frontend-designfiles (byte-identical to upstream, Apache-2.0), manifest entry and hashes, removedgrill-medirectories,docs/AI_WORKFLOW.mdprovenance edits.codex execinvocation across Codex CLI versions (-c model_reasoning_effort, saving the final message). It was verified on this machine withcodex review, not with this exactexeccommand.Task size
T1: agent workflow files, docs and skill-sync scripts. No application code and no T2 paths (Review signals: no T2-area files).
Checks
node scripts/sync-agent-skills.mjs --checknode scripts/check-engineering-workflow.mjsnode --test scripts/*.test.mjsnode scripts/check-migration-history.mjs origin/main HEADnode scripts/check-pr-review-signals.mjs origin/main HEADgit diff --check, relative link checkpnpm lint/test/build/typecheckUnverified boundaries
Agent behavior with the new skills (whether Claude invokes
codex-reviewat the T2 review step on its own) is untested until the first real T2 task.Review
T1 self-review by the author. No independent review: no T2 or guard paths changed.
Docs and temporary files
AGENTS.mdanddocs/AI_WORKFLOW.mdupdated as owning documents. Local task directory.tmp/review-and-ship-skills/(worktree and transfer bundle) stays until merge.Generated by Claude Code