Skip to content

Claude workflows: strict permission mode, action v1.0.280, Semgrep severities, Dependabot cooldown - #132

Merged
daniel-pittman merged 1 commit into
developfrom
ci/strict-permission-mode-and-cooldown
Nov 19, 2026
Merged

daniel-pittman merged 1 commit into
developfrom
ci/strict-permission-mode-and-cooldown

Conversation

@daniel-pittman

Copy link
Copy Markdown
Owner

What this changes

  • Strict permission mode on every Claude step. From claude-code-action v1.0.273, a session without --permission-mode starts in auto mode. A safety review can then approve a tool call that no allow rule covers, so --allowedTools stops being a strict list. The review step already set --permission-mode default. The @claude workflow and the verdict extractor now set it too.
  • claude-code-action v1.0.280 (469588f) on every step.
  • Semgrep severities. The Semgrep comment's summary counted only the older severity names (ERROR, WARNING, INFO). Its table labeled everything else LOW. Semgrep now reports some rules with the newer names: p/ci's dependabot-missing-cooldown reports MEDIUM, for example. Such a finding was counted as zero and shown as LOW, and the Claude review reads that comment. One jq mapping (sev) now feeds both the counts and the table: ERROR, CRITICAL and HIGH map to HIGH; WARNING and MEDIUM map to MEDIUM; INFO and LOW map to LOW.
  • The verdict extractor counts only the review's own findings. The review restates the Semgrep and CI summaries, which can now carry HIGH counts for findings already in the repository. The extractor prompt says those are not review findings, and that a review with no findings is a PASS. (Found live: without it, a PR the review passed was blocked.)
  • Dependabot cooldown. Every updates: entry has cooldown: default-days: 7. Dependabot proposes a version only after it has been out a week, since a compromised or mistaken release is usually caught within days. Security updates are not delayed.

How it was checked

  • Workflow tests: this repository's workflows and dependabot.yml pass the shared workflow checks. Four new checks fail on the previous files:
    • test_every_action_step_pins_the_permission_mode: exactly one --permission-mode, and it is default, on every action step.
    • test_semgrep_counts_and_table_share_one_severity_mapping: every severity use goes through sev, evaluated on all seven names.
    • test_every_dependabot_update_waits_out_a_cooldown.
    • test_the_extractor_counts_only_the_reviews_own_findings.
  • actionlint: reports nothing.
  • Semgrep live: Semgrep's p/ci rules on a dependabot.yml without a cooldown report three MEDIUM findings. The previous comment code counted 0 and labeled them LOW; the new mapping counts 3 MEDIUM.
  • Not exercised on this PR: the Claude review. The review action skips any PR that edits its own workflow, so this PR's review reads INCONCLUSIVE.

🤖 Generated with Claude Code

…verities, Dependabot cooldown

- Every claude-code-action step passes --permission-mode default. From
  v1.0.273 a session without a mode starts in auto mode, where a safety
  review can approve a tool call no allow rule covers, so --allowedTools
  stops being a strict list. The review step already set it; the @claude
  bot and the verdict extractor now do too.
- claude-code-action moves to v1.0.280 (469588f) on every step.
- The Semgrep comment counted only the older severity names (ERROR,
  WARNING, INFO) and labeled everything else LOW, so a finding reported
  as MEDIUM or HIGH was counted as zero and shown as LOW. One jq mapping
  now feeds both the counts and the table.
- The verdict extractor counts only the review's own findings, never
  the Semgrep or CI counts the review restates (with the severities
  mapped, those can carry HIGH counts for findings already in the
  repository).
- Every Dependabot ecosystem waits 7 days after a release before a
  version update (cooldown). Security updates are not delayed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

Semgrep (OSS): no findings

Clean scan. Posted before the Claude review.

@github-actions

Copy link
Copy Markdown

CI Tests

✅ Tests passed: the pytest suite across Python 3.10/3.11/3.12 (and bash syntax checks) are green on 49649eeaf.

Posted before the Claude review so the test outcome is folded into the review.

@github-actions

Copy link
Copy Markdown

Review Gate

⚠️ Gate: INCONCLUSIVE — The verdict extractor did not complete (job result: failure). Push a new commit to re-run the checks (they re-run on every push), or a maintainer can apply the review-ack label and then re-run this check (Re-run failed jobs).

@daniel-pittman
daniel-pittman merged commit 8430f6c into develop Nov 19, 2026
10 of 12 checks passed
@daniel-pittman
daniel-pittman deleted the ci/strict-permission-mode-and-cooldown branch November 19, 2026 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant