Skip to content

Debt remaining from #6: the find-box test's failure message #8

Open

Description

@daniel-pittman

Unresolved review items from #6 (Tests: fix a date-boundary test and a find-box test that matched its temp folder).

LOW: a failing wait no longer prints the list

  • tests/test_resume.py, test_find_box_filters_and_resumes: the filter check is a settle wait, which fails with only "condition never held". After the wait, assert the shown names, for example self.assertEqual([e["name"] for e in app.screen.shown][:1], ["Docs Site"]), so a real regression prints the list it got.

Done when the assertion is added and FLEETWATCH_NO_MIGRATE=1 python -m unittest tests.test_resume passes.

Activity

  1. daniel-pittman commented on Nov 16, 2026

    @daniel-pittman
    OwnerAuthor

    One more small test-quality item for whoever picks this up:

    • Rename test_a_cancelled_run_posts_no_gate in tests/test_workflows.py (line 362) to test_a_canceled_run_posts_no_gate, so the project's spelling stays American. The !cancelled() the test asserts on is the GitHub Actions function and must stay as it is.
  2. daniel-pittman commented on Nov 18, 2026

    @daniel-pittman
    OwnerAuthor

    The test_a_cancelled_run_posts_no_gate rename is done in #13 (now test_a_canceled_run_posts_no_gate). The find-box failure-message item above is still open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    tech-debtAccepted debt: low-severity follow-ups

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions