Open
Conversation
Update to load PAM tiem measurements
Fixed numpy nan error
Test data is too large
Update to load PAM tiem measurements
Fixed numpy nan error
Test data is too large
a58bcff to
246c322
Compare
|
|
Overall Grade |
Security Reliability Complexity Hygiene Coverage |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| Python | Mar 4, 2026 8:54p.m. | Review ↗ | |
| Test coverage | Mar 4, 2026 8:54p.m. | Review ↗ |
Code Coverage Summary
| Language | Line Coverage (New Code) | Line Coverage (Overall) |
|---|---|---|
| Aggregate | 94% [⤫ below threshold] |
99.9% [▼ down 0.1% from main] |
| Python | 94% [⤫ below threshold] |
99.9% [▼ down 0.1% from main] |
➟ Additional coverage metrics may have been reported. See full coverage report ↗
…rthcenter/plantcv into 1862-import-pam-time-files
Update for deepsource error, frame_nums is not needed in pmt import because they are all relabeled
There was a problem hiding this comment.
Pull request overview
This PR adds support in read_cropreporter.py for importing PMT (PAM Time) datasets from PhenoVation CropReporter files so they can be used in quenching analyses, along with new test data, tests, and documentation updates.
Changes:
- Add PMT dataset parsing (
_process_pmt_data) and attach results asps.pam_time. - Add PMT
.INFtest fixtures and new unit tests covering 9- and 13-frame PMT cases. - Update user documentation to mention PAM Time imports and include a new example image.
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
plantcv/plantcv/photosynthesis/read_cropreporter.py |
Adds PMT/“pam_time” import path and debug visualization output. |
tests/plantcv/photosynthesis/test_read_cropreporter.py |
Adds new PMT-only tests for 9- and 13-label PMT imports. |
tests/plantcv/photosynthesis/conftest.py |
Adds PMT testdata directory/path and attempts to add a pam_time mock data branch. |
docs/photosynthesis_read_cropreporter.md |
Documents pam_time and adds a screenshot reference for PMT frames. |
tests/testdata/cropreporter_pmt/HDR_E0001P0007N0001_GCU24100090_20260226.INF |
Adds PMT-related metadata fixture (P0007). |
tests/testdata/cropreporter_pmt/HDR_E0001P0008N0001_GCU24100090_20260226.INF |
Adds PMT-related metadata fixture (P0008). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Update read_cropreporter.py to import PMT (PAM time) files from Phenovation software for quenching analysis. Documentation and tests have been updated.
Type of update
Is this a:
Associated issues
Issue 1862
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.ymlupdating.md