Skip to content

1862 import pam time files#1884

Open
kmurphy61 wants to merge 60 commits intov5.0from
1862-import-pam-time-files
Open

1862 import pam time files#1884
kmurphy61 wants to merge 60 commits intov5.0from
1862-import-pam-time-files

Conversation

@kmurphy61
Copy link
Contributor

Describe your changes
Update read_cropreporter.py to import PMT (PAM time) files from Phenovation software for quenching analysis. Documentation and tests have been updated.

Type of update
Is this a:

  • New feature or feature enhancement

Associated issues
Issue 1862

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@kmurphy61 kmurphy61 force-pushed the 1862-import-pam-time-files branch from a58bcff to 246c322 Compare February 26, 2026 16:43
@deepsource-io
Copy link

deepsource-io bot commented Feb 26, 2026

DeepSource Code Review

We reviewed changes in ff465ec...2bd2984 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Coverage  

Code Review Summary

Analyzer Status Updated (UTC) Details
Python Mar 4, 2026 8:54p.m. Review ↗
Test coverage Mar 4, 2026 8:54p.m. Review ↗

Code Coverage Summary

Language Line Coverage (New Code) Line Coverage (Overall)
Aggregate
94%
[⤫ below threshold]
99.9%
[▼ down 0.1% from main]
Python
94%
[⤫ below threshold]
99.9%
[▼ down 0.1% from main]

➟ Additional coverage metrics may have been reported. See full coverage report ↗

Update for deepsource error, frame_nums is not needed in pmt import because they are all relabeled
@kmurphy61 kmurphy61 added the update Updates an existing feature/method label Feb 26, 2026
@nfahlgren nfahlgren added this to the PlantCV v5.0 milestone Mar 2, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support in read_cropreporter.py for importing PMT (PAM Time) datasets from PhenoVation CropReporter files so they can be used in quenching analyses, along with new test data, tests, and documentation updates.

Changes:

  • Add PMT dataset parsing (_process_pmt_data) and attach results as ps.pam_time.
  • Add PMT .INF test fixtures and new unit tests covering 9- and 13-frame PMT cases.
  • Update user documentation to mention PAM Time imports and include a new example image.

Reviewed changes

Copilot reviewed 6 out of 8 changed files in this pull request and generated 10 comments.

Show a summary per file
File Description
plantcv/plantcv/photosynthesis/read_cropreporter.py Adds PMT/“pam_time” import path and debug visualization output.
tests/plantcv/photosynthesis/test_read_cropreporter.py Adds new PMT-only tests for 9- and 13-label PMT imports.
tests/plantcv/photosynthesis/conftest.py Adds PMT testdata directory/path and attempts to add a pam_time mock data branch.
docs/photosynthesis_read_cropreporter.md Documents pam_time and adds a screenshot reference for PMT frames.
tests/testdata/cropreporter_pmt/HDR_E0001P0007N0001_GCU24100090_20260226.INF Adds PMT-related metadata fixture (P0007).
tests/testdata/cropreporter_pmt/HDR_E0001P0008N0001_GCU24100090_20260226.INF Adds PMT-related metadata fixture (P0008).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

kmurphy61 and others added 14 commits March 2, 2026 13:50
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@nfahlgren nfahlgren requested a review from Copilot March 4, 2026 20:45
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to review update Updates an existing feature/method

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants