Handle checkpointed workflows that fail entirely#1883
Open
joshqsumner wants to merge 4 commits intov5.0from
Open
Handle checkpointed workflows that fail entirely#1883joshqsumner wants to merge 4 commits intov5.0from
joshqsumner wants to merge 4 commits intov5.0from
Conversation
 |
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| Python |  |
Feb 25, 2026 5:53p.m. | Review ↗ |
| Test coverage | |
Feb 25, 2026 5:53p.m. | Review ↗ |
Code Coverage Summary
| Language | Line Coverage (New Code) | Line Coverage (Overall) |
|---|---|---|
| Aggregate | 100% [✓ above threshold] |
100% |
| Python | 100% [✓ above threshold] |
100% |
➟ Additional coverage metrics may have been reported. See full coverage report ↗
joshqsumner
added
bugfix
joshqsumner
added
ready to review
and removed
work in progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Updating
parsers._read_checkpoint_datalogic to only try to find checkpointing information if any jobs were completed successfully (ie, hadargs.resultsaccessed). This fixes a bug that appeared when running a checkpointed parallel workflow that did not have any jobs complete successfully and made the re-run give a pandas key error since thealready_rundf was empty.Also labels log directories more explicitly in case logs are being written to "." or somewhere else that could have non-logs stuff in it as well.
Type of update
This is a bug fix.
Associated issues
None
Additional context
None
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.ymlupdating.md