Open
Conversation
Add GFP, RFP, APH support for read_cropreporter
Image sharpening
Params verbosity
Remove utils module
Rename filepath to dir
  DeepSource reviewed changes in the commit range For detailed review results, please see the PR on DeepSource ↗ PR Report Card
Code Review Summary
How are these analyzer statuses calculated?Administrators can configure which issue categories are reported and cause analysis to be marked as failed when detected. This helps prevent bad and insecure code from being introduced in the codebase. If you're an administrator, you can modify this in the repository's settings. Code Coverage Summary
➟ Additional coverage metrics may have been reported. See full coverage report ↗ |
|||||||||||||||||||||||||||||||||||||||||||||||
nfahlgren
added
work in progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
The
pcv.roi.quick_filtermethod was added to improve the performance ofpcv.roi.filter. While it is significantly faster, this PR aims to improve performance a little more. The updated approach only impacts the partial overlap method (the slowest). The core update is that the labeled mask + ROI mask is first condensed to a set of unique pixel values and these are filtered for values where a label and the ROI intersect. Then only these objects are added to the output mask. The performance of this approach will be faster when there are more objects outside the ROI because the old approach iterated over all objects.Type of update
Is this a: New feature or feature enhancement
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.ymlupdating.md