Merged
Conversation
 |
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| Python |  |
Feb 23, 2026 9:14p.m. | Review ↗ |
| Test coverage | |
Feb 23, 2026 9:18p.m. | Review ↗ |
Code Coverage Summary
| Language | Line Coverage (New Code) | Line Coverage (Overall) |
|---|---|---|
| Aggregate | 100% |
100% |
| Python | 100% |
100% |
➟ Additional coverage metrics may have been reported. See full coverage report ↗
k034b363
added
new feature
changed docstring style and flake8 for test.
maliagehan
approved these changes
Feb 24, 2026
Member
maliagehan
left a comment
maliagehan
left a comment
There was a problem hiding this comment.
Reviewed, and put review notebook in drive. I debated if we should combine the required add shape step into the box function (list of layers?), but there may be reasons not to do this for this version.
Member
There was a problem hiding this comment.
Changed the docstring format (we still need to do this on other files in the repo, but this one has been changed to numpydoc style)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adds a function that takes a napari viewer object with a shapes layer that has rectangular polygons and outputs a list of x, y, height, and width of the rectangle suitable for either defining an ROI or specifying a bounding box for segment anything.
Type of update
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.ymlchangelog.md