Remove fragile --test-args parsing, pass unknown args directly to vitest

[Copilot]

The --test-args= implementation split values by spaces, breaking arguments containing spaces even when quoted (e.g., --grep "test pattern").

Changes

• Remove --test-args= special handling and error on unknown options
• Treat all unrecognized arguments as vitest passthrough args
• Update help text to reflect cleaner interface

Before/After

# Before: fragile, breaks on spaces
npm run qa -- --test-args='--run --coverage'
npm run qa -- --test-args='--grep "my test"'  # BROKEN

# After: robust, preserves shell quoting
npm run qa -- --run --coverage
npm run qa -- --grep "my test pattern"

Arguments now rely on shell's native parsing instead of custom string splitting.

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[coderabbitai]

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Note

Free review on us!

CodeRabbit is offering free reviews until Fri Nov 07 2025 to showcase some of the refinements we've made.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull Request Overview

This PR simplifies the argument handling in the agent-check.mjs script by removing the explicit --test-args flag and instead treating all unrecognized arguments as passthrough arguments for Vitest. This makes the CLI more intuitive and follows standard npm argument passing conventions.

Key Changes:

• Removed the --test-args= flag parsing logic
• Changed unknown argument handling from erroring to passthrough
• Updated help text to reflect the new argument passing pattern

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Handle -- separator instead of forwarding it to Vitest

The new parsing loop now pushes every unrecognized token into passthroughArgs, including the literal --. When running QA with both script flags and Vitest flags (e.g. npm run qa -- --skip-build -- --grep "pattern"), the loop forwards ['--', '--grep', 'pattern'] and line 55 prepends another --. vitest therefore receives npm run test:unit -- -- --grep pattern --passWithNoTests, where the second -- stops option parsing and all subsequent flags (--grep, --passWithNoTests, etc.) are ignored. Custom test arguments no longer work and the safety flag --passWithNoTests is lost whenever passthrough args are used. The parser should treat -- as a separator (stop parsing and exclude it) before building testArgs.

Useful? React with 👍 / 👎.

[danelkay93]

@copilot Fix this

[Copilot]

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.