Repository navigation
fix: guard placeholder arguments and print-only claims (#715's shapes), for release/v0.1 - #734
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cherry-picks #716 (main 76e6064, branch head f8aa000) onto release/v0.1 at 8530362. #716's merge diff applied cleanly.
It covers the two shapes the shipped-pack actbench found in #715:
pkg_remove("package_name")) runs nothing. The shell asks which one is meant, and a script that holds such a literal is refused.It's shellcore only:
guard.rs, its tests, and the hooks in actions, agentcore and lib. On release it sits after #731's telling-line refusal, as it does on main: the placeholder check runs first, then the telling-line refusal, then the tier.Gates on main (#716):
Test plan
The manager merges this by hand.