Add function for keep alive with arbitrary duration#11
Open
moznion wants to merge 1 commit intodane:masterfrom
Open
Add function for keep alive with arbitrary duration#11moznion wants to merge 1 commit intodane:masterfrom
moznion wants to merge 1 commit intodane:masterfrom
Conversation
moznion
force-pushed
the
keep_alive_duration_to_be_configurable
branch
from
fa15b84 to
2348006
Compare
moznion
changed the title
| c.KeepAliveBy(60) | ||
| } | ||
|
|
||
| // KeepAlive is meant to run as a goroutine. It sends a single whitespace |
Collaborator
There was a problem hiding this comment.
I think KeepAlive should be KeepAliveBy? Just a copy-paste typo I think
Collaborator
|
@moznion very sorry about my delayed responses! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Duration of
KeepAlive()is hard-coded so we cannot change that. Accordingly, I added a new functionKeepAliveBy(sec time.Duration)to configure duration.Related: #12