Open
Conversation
Owner
|
Get in mate! I will take a look at this tomorrow at work. |
Author
|
I didn't understood "This needs to go upstream in https://github.com/damianh/LibLog" Is the LibLog an external dependency? |
|
Guys, anyone working on porting to net core? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Can you please take a look at this PR? I updated the project to support .net core (running on linux).
For what I tested (basic auth, say, play, hangup) it works as the .net 451 version.
I have some questions regarding the "Serializable" classes you have. Is the Serializable used to pass the object through tcp? From my tests, I can see it isn't used in the core library, but for third party consumers, this could be a break change as .NET Core does not support serialization yet.
Well, please take a look and tell me if I can help in anything.