FR 101 - #102
Merged
Merged
FR 101#102
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
checkClockSkew() needs mode-safe handling (avoid dialog updates/sleeps in Silent/Test while still recording results) and there are minor version/date/UI inconsistencies to resolve.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds a new Jamf Pro–specific health check to detect meaningful local clock skew (via sntp time.apple.com) before attempting Jamf inventory submission, and updates the docs/diagrams/versioning to reflect the new check.
Changes:
- Added
checkClockSkew()and wired it into the Jamf Pro run sequence, plus Inspect Summary mappings (category, criticality, explanation/remediation). - Updated Jamf Pro list items / indices to include the new “Clock Skew” check.
- Bumped documented version references and updated docs/diagrams/changelog to include the new check.
File summaries
| File | Description |
|---|---|
| README.md | Updates version text and documents the new Clock Skew behavior for Jamf Pro runs. |
| Mac-Health-Check.zsh | Implements checkClockSkew(), updates Jamf Pro list items and run order, and adds Inspect Summary support for the new check. |
| Diagrams/06-health-check-reference.md | Updates Development-mode note and adds checkClockSkew() to the reference table. |
| Diagrams/03-health-check-categories.md | Adds Clock Skew to the MDM category diagram/table. |
| CHANGELOG.md | Updates the 4.2.0b2 section to include the new check. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+7665
to
+7669
| dialogUpdate "icon: SF=clock,${organizationColorScheme}" | ||
| dialogUpdate "listitem: index: ${1}, icon: SF=$(printf "%02d" $(($1+1))).circle.fill $(echo "${organizationColorScheme}" | tr ',' ' '), iconalpha: 1, status: wait, statustext: Checking …" | ||
| dialogUpdate "progress: increment" | ||
| dialogUpdate "progresstext: Determining ${humanReadableCheckName} …" | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses Feature Request #101
checkClockSkew()to Jamf Pro runs to detect local clock offset againsttime.apple.combefore inventory submission and flag skew above 5 minutes