Draft
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a new get_groupable_players service to the media_player component that returns a list of media players that can be grouped together for synchronized playback. The service is restricted to entities with GROUPING feature support and returns only players from the same platform as the calling entity.
Changes:
- Adds new service
get_groupable_playerswith service response support - Implements
async_get_groupable_playersmethod that filters media players by platform and GROUPING feature - Includes comprehensive test coverage for the new service functionality
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| homeassistant/components/media_player/init.py | Adds entity_registry import, registers new service, and implements async_get_groupable_players method |
| homeassistant/components/media_player/const.py | Defines SERVICE_GET_GROUPABLE_MEMBERS constant |
| homeassistant/components/media_player/services.yaml | Adds service definition and includes unrelated max value change |
| homeassistant/components/media_player/strings.json | Adds service name and description |
| homeassistant/components/media_player/icons.json | Adds service icon |
| tests/components/media_player/test_init.py | Adds 4 test cases covering basic functionality, feature validation, platform filtering, and multiplatform scenarios |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@dan-s-github I've opened a new pull request, #3, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: dan-s-github <20974454+dan-s-github@users.noreply.github.com>
Co-authored-by: dan-s-github <20974454+dan-s-github@users.noreply.github.com>
Fix cross-platform grouping tests for get_groupable_players
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR implements the service portion of the feature request from Discussion #2342, adding
media_player.get_groupable_playersservice that allows users and automations to dynamically discover which media players can be grouped together for synchronous playback.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: