Repository navigation
Align with RFC 9864 (fully-specified algorithms) - #709
Merged
dajiaji merged 1 commit intoNov 9, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #709 +/- ##
=======================================
Coverage 97.07% 97.07%
=======================================
Files 32 32
Lines 3490 3490
=======================================
Hits 3388 3388
Misses 102 102 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
achamayou
marked this pull request as ready for review
November 8, 2026 22:24
Owner
|
Thanks @achamayou! LGTM. Could you rebase onto the latest |
draft-ietf-jose-fully-specified-algorithms-13 was published as RFC 9864. Code points are unchanged; update references, register Ed25519/Ed448 as JOSE algorithms, mark EdDSA/ES256/ES384/ES512 as deprecated in docs, and use Ed25519 instead of EdDSA in README examples and their mirrored tests. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
achamayou
force-pushed
the
achamayou-fully-specified-algorithms-rfc
branch
from
November 9, 2026 10:09
5970903 to
bbac77b
Compare
Contributor
Author
Of course! All done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
draft-ietf-jose-fully-specified-algorithms-13 has been published as RFC 9864. The COSE code points are unchanged from draft-13. This PR aligns references, constants and docs with the final RFC.
JOSE_ALGORITHMS_SUPPORTED: addEd25519andEd448, which RFC 9864 §4.1.1 registers as JOSE algorithms. JOSEEdDSAis now deprecated (§4.1.2).docs/algorithms.rstandconst.pycomments: markEdDSA,ES256,ES384andES512as deprecated (§4.2.2). Use the RFC descriptions for Ed25519 and Ed448.tests/test_cose_sample_with_encode.pyuseEd25519instead of the deprecatedEdDSA.Not changed: keys created without an
algstill default toEdDSAorES256/ES384/ES512. Switching the defaults to the fully-specified algorithms would change thealgin signed output and may break existing verifiers.I used AI to make this PR, but I did review all the changes and they are correct as far as I can tell. Keeping defaults unchanged when alg is not specified may be timid, but seems safest.