fix false positives for identity matrix #442#541
Merged
NSoiffer merged 1 commit intodaisy:mainfrom Apr 2, 2026
Merged
Conversation
This commit introduces new test cases for handling identity matrices across multiple languages (`en`, `de`, `nb`). It also updates the rules for correctly distinguishing identity matrices by ensuring stricter conditions on diagonal and off-diagonal elements.
Collaborator
|
Thanks for the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #442.
The previous conditions specified in the
matchblock where too loose.Also added regression tests across the three affected languages.