fix: add spacing between plus button and mobile footer #5368
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increased bottom margin from bottom-24 to bottom-28 to prevent the plus button from being too close to the navigation bar.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Chris seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
omBratteng
approved these changes
Jan 24, 2026
- Updated FooterWrapper to use bottom-safe-or-0 instead of !bottom-0 - This should fix iOS PWA safe area issues where plus button appears attached - Also fixes webapp scroll behavior where button snaps to footer
rebelchris
commented
Jan 24, 2026
added 2 commits
January 24, 2026 04:37
Reduced from bottom-28 to bottom-20 since FooterWrapper now properly handles safe area with bottom-safe-or-0
- Reverted to fixed !bottom-0 so footer stays at bottom when scrolled - Added pb-safe to handle iOS safe area with padding instead of positioning - This should fix both scrolling behavior and iOS PWA safe area issues
- Use env(safe-area-inset-bottom, 0px) directly in inline style - Keeps footer at fixed bottom-0 for proper scroll behavior - Should work consistently across devices and PWA contexts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes spacing issue where the floating plus button was too close to the mobile footer navigation bar.
Changes
bottom-24(96px) tobottom-28(112px)Before/After
Before: Plus button directly attached to footer bar
After: Proper spacing between plus button and footer bar
Testing
Preview domain
https://fix-plus-button-spacing.preview.app.daily.dev