Repository navigation
fix: repair component state, accessibility and previews - #35
Merged
Merged
Conversation
|
|
Important Review skippedToo many files! This PR contains 377 files, which is 277 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. Usage-priced reviews support at most 300 files.
 |
daguanren21
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem / Goal
Native documentation previews and several Registry components rendered incorrectly or did not demonstrate their actual behavior. The follow-up audit covered all 69 catalog entries: omitted native values could become zero/empty values, disabled or unchanged actions emitted mutations, keyboard actions and custom slot semantics were incomplete, and some component pages had no working demo.
Concrete failures included decimal InputNumber values losing precision, failed images remaining in a loading state after hydration, a clipped NoticeBar close button, missing translated Steps labels, and SwipeCell demo controls moving out of reach with the sliding content.
Changes
false,0and empty strings. Keep Form error visibility reactive; enforce disabled, readonly, canceled and unchanged-state guards without suppressing explicit confirmation, selection or dismissal actions.Control and variant sweep
One integration owner coordinated independent H5 and native slices. Source review and real-browser verification returned concrete findings to the owning component; already-passing scenarios were retained. The sweep covered absent-versus-falsy initialization, accepted mutations versus actions, keyboard/cancellation boundaries, accessible slot ownership, preview availability, image lifecycle, narrow layouts and list-style isolation. Breadcrumb already isolates its horizontal list spacing; Steps now follows the same ownership rule. Native HTML controls retain browser-owned keyboard activation.
Verification
pnpm check:generatedandpnpm check:architecture: 865 projections clean; 557 product source files checkedRoot lint scripts are placeholders; substantive linting is the mandatory staged gate above. Browser findings were repaired and checked on rebuilt artifacts. Focused tests run from their owning packages to exclude unrelated sibling worktrees. No test deadlines, platform admission rules or safety checks were weakened.
Compatibility and limits
Public component signatures and native tuple event shapes remain unchanged. Horizontal Steps intentionally uses a marker-above-label layout to preserve translated labels in narrow containers. Native evidence includes compiled artifacts, headless WeChat execution and Chromium preview; it does not certify physical devices, other browser engines or the full external SDK/signing matrix. Jev scores were auxiliary signals and were not used as acceptance evidence.
Rollback
Revert the component changes together with their generated projections. No data migration is involved. This PR is a component and documentation-preview audit follow-up, with no linked issue.