Skip to content

fix(docs): polish inline code selection and spacing - #2000

Open
junghyeonsu wants to merge 2 commits into
devfrom
fix/docs-inline-code-selection
Open

fix(docs): polish inline code selection and spacing#2000
junghyeonsu wants to merge 2 commits into
devfrom
fix/docs-inline-code-selection

Conversation

@junghyeonsu

@junghyeonsu junghyeonsu commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Unify inline code styling across MDX content, the table of contents, and changelog entries.
  • Preserve continuous text selection around inline code by using a 2px visual inset without horizontal layout padding.
  • Add 2px vertical padding on each side and reset the inline marker treatment inside fenced code blocks.
  • Use a consistent dark-on-lime selection treatment throughout the documentation site.

Test plan

  • Run bun install --frozen-lockfile.
  • Run bun headless:build.
  • Run bun generate:all.
  • Run bun test:all.
  • Run bun --filter @seed-design/docs typecheck.
  • Run bun biome check against the changed files.
  • Verify text selection and table-of-contents inline code on the Dialog documentation page.

@changeset-bot

changeset-bot Bot commented Aug 13, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 87d4aee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 1d90b565-eb77-40b0-9252-c9ef33884bfb

📥 Commits

Reviewing files that changed from the base of the PR and between 945df9a and 85986a2.

📒 Files selected for processing (8)
  • docs/app/global.css
  • docs/components/changelog-entry-item.test.tsx
  • docs/components/changelog-entry-item.tsx
  • docs/components/inline-code.test.tsx
  • docs/components/inline-code.tsx
  • docs/components/mdx-components.tsx
  • docs/components/table-of-contents.test.tsx
  • docs/components/table-of-contents.tsx

📝 Walkthrough

Walkthrough

문서에 공통 InlineCode 컴포넌트와 재귀 렌더러를 추가했습니다. MDX, 변경 로그, 목차가 이를 사용합니다. 전역 텍스트 선택 스타일도 통합했습니다. 각 렌더링 경로의 스타일 테스트를 추가했습니다.

Changes

인라인 코드 렌더링 통합

Layer / File(s) Summary
공통 인라인 코드 컴포넌트와 MDX 연결
docs/components/inline-code.tsx, docs/components/mdx-components.tsx, docs/components/inline-code.test.tsx
공통 스타일 상수, InlineCode, renderInlineCode를 추가했습니다. MDX의 code 렌더러를 InlineCode에 연결했습니다. 렌더링과 스타일 테스트를 추가했습니다.
문서 구성 요소 렌더링 통합
docs/components/changelog-entry-item.tsx, docs/components/changelog-entry-item.test.tsx, docs/components/table-of-contents.tsx, docs/components/table-of-contents.test.tsx
변경 로그와 목차의 인라인 코드가 공통 스타일과 renderInlineCode를 사용하도록 변경했습니다. 두 구성 요소의 렌더링 테스트를 추가했습니다.
전역 텍스트 선택 스타일
docs/app/global.css
코드 블록의 user-select 선언에서 !important를 제거했습니다. 선택 영역 스타일을 전역 ::selection으로 통합했습니다.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Mergeability Score: ⚪ Minimal · up to 85986

This localized documentation styling change is merge-ready after normal checks and review; no actionable merge-blocking risk remains.

Sequence Diagram(s)

sequenceDiagram
  participant MDXContent
  participant MDXRenderer
  participant InlineCode
  participant SeedTableOfContents
  MDXContent->>MDXRenderer: 인라인 code 렌더링 요청
  MDXRenderer->>InlineCode: code 요소 렌더링
  SeedTableOfContents->>InlineCode: 목차 제목의 code 요소 변환
  InlineCode-->>MDXRenderer: 스타일이 적용된 code 요소
  InlineCode-->>SeedTableOfContents: 스타일이 적용된 code 요소
Loading
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 제목은 인라인 코드의 선택 영역과 여백을 정리하는 주요 변경 사항을 정확하고 간결하게 설명합니다.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/docs-inline-code-selection

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Alpha Preview (Stackflow SPA)

@github-actions

github-actions Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Alpha Preview (Storybook)

@junghyeonsu junghyeonsu changed the title fix(docs): 인라인 코드 선택 영역과 여백을 정리해요 fix(docs): polish inline code selection and spacing Aug 13, 2026
@github-actions

github-actions Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Alpha Preview (Docs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant