Show relative time ("N seconds/minutes ago (at HH:MM)") for recent clips#18
Open
faizanafz wants to merge 1 commit into
Open
Show relative time ("N seconds/minutes ago (at HH:MM)") for recent clips#18faizanafz wants to merge 1 commit into
faizanafz wants to merge 1 commit into
Conversation
… the last hour For clips recorded within the last 3600s, format_date now returns a relative label paired with the wall-clock time, e.g. "25 seconds ago (at 22:38)" or "15 minutes ago (at 20:24)". Older items keep the existing Today/Yesterday/date formats.
Owner
|
Thanks for the PR! A few things before merge:
Happy to re-review once tests pass and the label refreshes on show. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a relative-time label to the list row timestamp for clips recorded within the last hour. Older items are unchanged.
just now (at HH:MM)for < 5sN seconds ago (at HH:MM)for < 60sN minutes ago (at HH:MM)for < 1hToday at HH:MM/Yesterday at .../ date formatsThe change is contained to
clipse_gui/utils.py::format_date. Implemented by checking(now - dt).total_seconds()against3600before falling through to the existing date logic, so behavior for non-recent items is byte-identical.Notes
< 3600; can be moved to a config value if useful.Test plan