Pin d3-selection dep to 3.0.0 - #274
Open
OliverMadine wants to merge 1 commit into
Open
Conversation
Member
|
That doesn’t seem right. First, selection.interrupt is provided by d3-transition, not d3-selection. And second, selection.interrupt has existed since version 0.0.5 of d3-transition; see d3/d3-transition@46bbcd6. You probably have a different issue which is duplicate versions of d3-selection installed, preventing d3-transition from modifying d3.selection.prototype. |
Author
|
Ah my bad, I took this comment thread at face value. fwiw, the issue is as you described with this structure (image from here) Upgrading
I'm mostly questioning this part |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

zoom.transform uses selection.interrupt
which conflicts if not using d3-selection 3.0.0 onwardswhich may conflict with different versions of d3-selection installed