1.0? - #19
Open
Fil wants to merge 21 commits into
Open
Conversation
- using hexbin.context([context]), hexbin.hexagon() and hexbin.mesh() support canvas ; fixes #1 - incremental updates: bins.add(point); bins.addAll(points); remove(point); bins.removeAll(points); fixes #3 - hexbin.angle([angle]) sets or reads an angle (default 0°, use 90° for flat-topped hexagons) ; fixes #8
…ifferent order) note: I made it be a setter, which sort of duplicates hexbin(data)
- remove .data(), instead use bins.flat() to get the data, and hexbin() to update without adding points. - don't rebin aggressively when changing parameters, only on update ie when calling hexbin() - all the new methods are on hexbin not on bins
Including a bit more centers solves the issue. The solution breaks a test on centers() in the angle=0 case, which we could keep backwards compatible by testing for angle===0; but I don't think it's a problem if we have a few more centers (better safe than sorry).
Closed
Member
Author
|
i've updated https://observablehq.com/@fil/d3-hexbin-playground to use the new code. |
Member
Author
|
@mbostock can we go with this? It would make a nice 1.0 version |
Member
Author
|
Here is another use case for the |
16 tasks
|
@Fil any update on this? |
Member
Author
|
Wow I forgot about this. It's only been 4½ years! I might have to review the code a bit. Have you tried it? |
Fil
commented
Feb 19, 2025
| @@ -9,7 +9,7 @@ Hexagonal binning is useful for aggregating data into a coarser representation f | |||
| If you use NPM, `npm install d3-hexbin`. Otherwise, download the [latest release](https://github.com/d3/d3-hexbin/releases/latest). You can also load directly from [d3js.org](https://d3js.org), either as a [standalone library](https://d3js.org/d3-hexbin.v0.2.min.js). AMD, CommonJS, and vanilla environments are supported. In vanilla, a `d3_hexbin` global is exported: | |||
Member
Author
There was a problem hiding this comment.
Suggested change
| If you use NPM, `npm install d3-hexbin`. Otherwise, download the [latest release](https://github.com/d3/d3-hexbin/releases/latest). You can also load directly from [d3js.org](https://d3js.org), either as a [standalone library](https://d3js.org/d3-hexbin.v0.2.min.js). AMD, CommonJS, and vanilla environments are supported. In vanilla, a `d3_hexbin` global is exported: | |
| If you use NPM, `npm install d3-hexbin`. Otherwise, download the [latest release](https://github.com/d3/d3-hexbin/releases/latest). You can also load directly from [d3js.org](https://d3js.org), either as a [standalone library](https://d3js.org/d3-hexbin.v1.min.js). AMD, CommonJS, and vanilla environments are supported. In vanilla, a `d3_hexbin` global is exported: |
(I think we'll want to update the distribution pattern.)
|
Less than 5 years ago should still be OK, right? 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #17 ; in this version, changing accessors does not result in the (awkward) rebinning of already-present points.
Closes #1 #3 #5 #8 #18.