Exclude home subdirs from isRootHomeOrSystemPath - #7
Open
vivienm wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I'm trying to use this package on Bluefin (Fedora Silverblue-based, with
HOMEunder/var, e.g./var/home/jdoe) and I'm hitting an over-broad hard-deny.When the agent runs a recursive
rmon any path under the user's home (e.g.rm -rf /var/home/jdoe/projects/foobar/build),isRootHomeOrSystemPathinextensions/auto-mode/hard-deny.tsreturnstrueand the command is unconditionally denied with "irreversible deletion of home/root/system paths is hard-denied".pi-automode/extensions/auto-mode/hard-deny.ts
Lines 159 to 178 in 87c047b
The
path === HOMEcheck is correct. The over-match comes from the system-roots branch:/varis insystemRoots, andpath.startsWith("/var/")swallows the wholeHOMEsubtree on distros where HOME lives under/var.The PR implements a minimal fix: exempt HOME's own subtree before checking system roots. This preserves
path === HOME(still blocksrm -rf ~), keeps/var/log,/etc, etc. protected, and only stops the rule from swallowing~/...on/var/homedistros.