Skip to content

Fix Lightbox backdrop dismissal - #588

Merged
czarandy merged 1 commit into
mainfrom
fix/453-lightbox-backdrop-dismiss
Aug 25, 2026
Merged

Fix Lightbox backdrop dismissal#588
czarandy merged 1 commit into
mainfrom
fix/453-lightbox-backdrop-dismiss

Conversation

@czarandy

Copy link
Copy Markdown
Owner

Summary

  • treat direct events on the Lightbox layout container as backdrop interactions
  • reuse press/release tracking so pan drags ending over the backdrop do not dismiss
  • add regression tests for real container clicks and pan-drag release behavior

Validation

  • pnpm test (166 files, 3490 tests)
  • pnpm lint
  • pnpm typecheck
  • pnpm build
  • Prettier check on changed files

Closes #453

Treat the full-viewport layout container as the visual backdrop while requiring both press and release to land there. Add regression coverage for backdrop clicks and pan drags that end outside the media.
@vercel

vercel Bot commented Aug 25, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
silver-ui-site Ready Ready Preview Aug 25, 2026 3:54am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
silver-ui Ignored Ignored Aug 25, 2026 3:54am

@czarandy
czarandy merged commit a234fad into main Aug 25, 2026
4 checks passed
@czarandy
czarandy deleted the fix/453-lightbox-backdrop-dismiss branch August 25, 2026 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lightbox: clicking the backdrop never dismisses it

1 participant