Skip to content

Fix merged ref cleanup semantics - #584

Merged
czarandy merged 1 commit into
mainfrom
fix/548-merge-refs
Aug 25, 2026
Merged

Fix merged ref cleanup semantics#584
czarandy merged 1 commit into
mainfrom
fix/548-merge-refs

Conversation

@czarandy

Copy link
Copy Markdown
Owner

Summary

  • always return a merged ref cleanup under React 19
  • run cleanup-returning callback refs while detaching plain callback and object refs
  • add a mixed-ref mount/unmount regression test

Testing

  • pnpm test (166 files, 3480 tests)
  • pnpm lint
  • pnpm typecheck
  • pnpm build

Closes #548

@vercel

vercel Bot commented Aug 25, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
silver-ui-site Ready Ready Preview Aug 25, 2026 12:03am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
silver-ui Ignored Ignored Aug 25, 2026 12:03am

@czarandy
czarandy enabled auto-merge (squash) August 25, 2026 00:07
@czarandy
czarandy merged commit d9a7bf1 into main Aug 25, 2026
4 checks passed
@czarandy
czarandy deleted the fix/548-merge-refs branch August 25, 2026 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mergeRefs: when any merged ref returns a cleanup, the other refs never see detach

1 participant