Merging with current QUDA develop#29
Open
pittlerf wants to merge 29 commits into
Open
Conversation
…d wall-source methods
Contributor
Author
This is compiling now with the with quda develop e2415ef161f06f439d5aa46bd1385ad14ea65105 (28.09.2022) |
sbacchio
approved these changes
Nov 25, 2022
sbacchio
left a comment
sbacchio
left a comment
Contributor
There was a problem hiding this comment.
Can be merged after merging Jacopo's
| set(CMAKE_CXX_FLAGS_DEVICEDEBUG "${OpenMP_CXX_FLAGS} -std=c++17 -Wall -Wno-unknown-pragmas ${CLANG_FORCE_COLOR}" CACHE STRING | ||
| "Flags used by the C++ compiler during device-debug builds.") | ||
| set(CMAKE_CXX_FLAGS_DEBUG "${OpenMP_CXX_FLAGS} -Wall -Wno-unknown-pragmas -g -fno-inline -DHOST_DEBUG ${CLANG_FORCE_COLOR}" CACHE STRING | ||
| set(CMAKE_CXX_FLAGS_DEBUG "${OpenMP_CXX_FLAGS} -std=c++17 -Wall -Wno-unknown-pragmas -g -fno-inline -DHOST_DEBUG ${CLANG_FORCE_COLOR}" CACHE STRING |
Contributor
There was a problem hiding this comment.
isn't enough the change in CUDA_NVCC_FLAGS?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now I see errors only coming from not declaring comm_rank() comm_abort() and function like these, so I hope I finish this today