Stop tagging the differ image :latest - #471
Merged
Merged
Conversation
Nothing reads it. docker-compose.yml names the image by
${CYBER_DOJO_DIFFER_IMAGE}:${CYBER_DOJO_DIFFER_TAG}, the short sha, and no
sibling repo names cyberdojo/differ:latest. Nothing passes it as cache_from
either, so the comments calling it the image-layer build cache described
nothing.
Keeping it had a cost. remove_all_but_current exempted :latest, so the build
it last pointed at survived every later build's cleanup, and the tag moving
to each new build left the previous image behind untagged. Removing the
exemption lets those go, and this build stays protected by its own sha tag,
which is what names it everywhere.
cyberdojo/differ:<sha> stays: local development names the differ image with
the dockerhub name the versioner env-vars carry rather than the ECR one.
mbevc1
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nothing reads it. docker-compose.yml names the image by
${CYBER_DOJO_DIFFER_IMAGE}:${CYBER_DOJO_DIFFER_TAG}, the short sha, and no
sibling repo names cyberdojo/differ:latest. Nothing passes it as cache_from
either, so the comments calling it the image-layer build cache described
nothing.
Keeping it had a cost. remove_all_but_current exempted :latest, so the build
it last pointed at survived every later build's cleanup, and the tag moving
to each new build left the previous image behind untagged. Removing the
exemption lets those go, and this build stays protected by its own sha tag,
which is what names it everywhere.
cyberdojo/differ: stays: local development names the differ image with
the dockerhub name the versioner env-vars carry rather than the ECR one.