Test that inspect emits language/test-framework versions - #35
Merged
Merged
Conversation
start-point inspect now surfaces the language and test_framework [name, version] pairs that its manifest-reading inspect.rb emits, but no test covered this. The existing custom-start-point test pins java-junit@01d6142, whose older manifest predates those fields, so it never exercises the version output. Add a test that pins ruby-minitest@6d16472 so the cloned manifest.json, and hence the reported Ruby 4.0.1 / MiniTest 6.0.0 versions, are deterministic and can be asserted exactly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
start-point inspect now surfaces the language and test_framework
[name, version] pairs that its manifest-reading inspect.rb emits, but
no test covered this. The existing custom-start-point test pins
java-junit@01d6142, whose older manifest predates those fields, so it
never exercises the version output.
Add a test that pins ruby-minitest@6d16472 so the cloned manifest.json,
and hence the reported Ruby 4.0.1 / MiniTest 6.0.0 versions, are
deterministic and can be asserted exactly.