Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions apps/dashboard/src/components/terminal/terminalHostStore.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,11 @@ const EMPTY_SNAPSHOT: TerminalHostSnapshot = {
};

export function getTerminalDescriptorKey(descriptor: TerminalHostDescriptor): string {
const grid = descriptor.letterbox
? `${descriptor.letterbox.cols}x${descriptor.letterbox.rows}`
: 'fit';
return `${descriptor.sessionId}\u0000${descriptor.paneId || ''}\u0000${grid}`;
// Identity is session+pane ONLY. Letterbox dims must never be part of the
// key: they can change while attached (topology updates), and a key change
// remounts the terminal — which detaches, releases the agentd size pin,
// changes the dims again, and loops attach/detach indefinitely.
return `${descriptor.sessionId}\u0000${descriptor.paneId || ''}`;
}

export function getTerminalWarmKey(descriptor: TerminalHostDescriptor): string {
Expand Down
Binary file modified apps/dashboard/src/components/tmux/TmuxTerminalWorkspace.tsx
Binary file not shown.
2 changes: 2 additions & 0 deletions tasks/frontend-ux-log.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,3 +50,5 @@
- ~06:40Z FW6-PRECISION froze at `adc996e` (attempt 1, 11 commits): gate re-run green incl. journeys, firewall clean (agentd touch = flagged shell-integration preamble with Go test). INTEGRATED (squash). VERIFY-R2 continuing on unblocked path.
- ~08:10Z FW6-VERIFY-R2 froze at `315c828` (attempt 4 across 2 honest holds — both surfaced real defects: dev-overlay tap interception; descriptor dropping hostId). All carried items + docs + 0.4.1 + device checklist delivered on 3% quota. INTEGRATED @ c7141be. WAVE-6 FINAL GATE GREEN: 21/21 smoke, 27/27 journeys, full TS+Go. Batch-2 adversarial review in flight.
- ~08:50Z Batch-2 adversarial review: SHIP-WITH-NOTES. HIGH: allow-passthrough set at server scope (-s) where it's a pane option — OSC-133 command marks were silently inert; fixed to -p with scope-asserting test. MED gesture-timer collision (450/500ms) fixed via cursor-armed cancellation; pointercancel activation guard; per-frame query parse cached (then made test-safe after a red test slipped one commit — grep-masked exit code, lesson noted). LOWs backlogged. CLOSING GATE GREEN. WAVE 6 COMPLETE — PR next; owner device checklist (docs/device-checklist.md) is the final acceptance item post-deploy.
- ~03:40Z (07-21) WAVE 6 MERGED (e8b9ce7, PR #91 — which turned out to be the never-merged close-out PR reused by gh; retitled) + DEPLOYED (SOURCE_COMMIT verified, agents:2). Tagged v0.4.1. agentd v0.4.1 binaries built on BOTH machines, staged for owner swap (policy). Remaining: owner binary swap + device checklist = program truly closed.
- ~03:47Z agentd v0.4.1 ROLLED OUT fleet-wide (homelinux via owner ! command; heavisidelinux completed by AI Lead after the wrapped-line mv failure — swap succeeded, reconnected). Both hosts on the Wave-6 binary. ONLY REMAINING ITEM: owner device checklist (docs/device-checklist.md).
2 changes: 2 additions & 0 deletions tasks/frontend-ux-metrics.jsonl
Original file line number Diff line number Diff line change
Expand Up @@ -33,3 +33,5 @@
{"ts":"2026-07-21T06:40:00Z","event":"lane_frozen","lane":"FW6-PRECISION","attempt":1,"frozen_sha":"adc996e","verdict":"accepted"}
{"ts":"2026-07-21T07:50:00Z","event":"lane_frozen","lane":"FW6-VERIFY","attempt":4,"frozen_sha":"315c828","verdict":"accepted","note":"two honest holds surfaced real defects"}
{"ts":"2026-07-21T08:50:00Z","event":"wave_complete","wave":6,"reviewer_verdicts":["SHIP-WITH-NOTES","SHIP-WITH-NOTES"],"gate":"green","defects_fixed_at_integration":9}
{"ts":"2026-07-21T03:40:00Z","event":"wave_deployed","wave":6,"sha":"e8b9ce7","tag":"v0.4.1"}
{"ts":"2026-07-21T03:47:00Z","event":"agentd_rollout_complete","version":"v0.4.1","hosts":["homelinux","heavisidelinux"]}
Loading