Skip to content

Wave 3: Command Center landing + in-app tmux management (Frontend Command Center UX program) - #88

Merged
cvsloane merged 13 commits into
mainfrom
refactor/frontend-command-center
Jul 20, 2026
Merged

cvsloane merged 13 commits into
mainfrom
refactor/frontend-command-center

Conversation

@cvsloane

@cvsloane cvsloane commented Jul 20, 2026 •

Copy link
Copy Markdown
Owner

Third wave — the visible one. Per-wave deploy cadence.

FW3-SHELL (5bba177)

  • The app now opens into the Command Center: the tmux/fleet surface is the root route; the v0.2.0 hero dashboard is deleted (stats relocated to Settings); /tmux is a query-preserving redirect; signin callback + PWA start_url target /.
  • One navigation model: bottom tabs Command Center / Attention / Sessions / More; header hamburger removed.
  • One attention surface: bell (desktop sheet) and tab (mobile page) share a single component tree; OrchestratorModal duplication deleted; /orchestrator deep links preserved.
  • Persistent launch rail (New / Recent / Open existing); MobileLaunchSheet is the single launch surface; legacy SpawnSessionDialog deleted; provider/template definitions centralized.

FW3-TMUX-UI (6526629 + R2 c2bcfbe)

  • Live topology store fed by tmux.topology with per-host roster fallback + 30s staleness TTL.
  • Window strip above the terminal: select/rename/kill/new window, bell/activity dots, optimistic with rollback; last-window kill hard-confirm (gated on authoritative topology).
  • Pane controls: splits (tmux≥3.1-gated percent), zoom, select-pane, kill-pane; desktop collapsible key bar.
  • Desktop 2-up independent terminals; mobile recent-pane quick-switch; virtualized scrollback history overlay on the Wave-2 endpoint.

Verification chain

  • Lane gates re-run independently at frozen SHAs; full integrated gate green (14/14 smoke incl. new tmux journeys).
  • Adversarial review: SHIP-WITH-NOTES, zero criticals; warnings closed in an R2 round (topology TTL, duplicate roster feed) + AI Lead fixes (canonical internal links, dead component); routing/PWA/terminal-lifecycle/deleted-surface risks explicitly cleared.

Deploy notes

  • No migrations. No agentd changes in this wave (binary rollout from Wave 2 still staged for owner on heavisidelinux).
  • Stale .next dev-cache note: after this route restructure, local dev environments should clear apps/dashboard/.next once.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features

    • Added a unified Command Center landing page with attention summaries and launch actions.
    • Added recent-launch access, repository history, and centralized launch options.
    • Added tmux window and pane controls, quick switching, two-terminal layouts, topology views, and paged terminal history.
    • Added connection-status indicators, improved navigation, and responsive mobile interactions.
    • Added usage and fleet snapshot metrics to Settings.
  • Bug Fixes

    • Standardized terminal navigation on the root route while preserving existing query parameters.
    • Improved focus states, touch targets, loading behavior, and stale topology handling.
  • Tests

    • Expanded unit and browser coverage for routing, launching, attention views, tmux controls, topology, and scrollback history.

cvsloane and others added 11 commits July 20, 2026 12:51
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
… launched

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…face, launch rail, legacy surfaces deleted (FW3-SHELL 5bba177)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…p terminals, mobile quick-switch, scrollback pager, desktop key bar (FW3-TMUX-UI 6526629)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ettingsButton (wave-3 review W3/N5)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…sion gating (FW3-TMUX-UI-R2 c2bcfbe)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 20, 2026 •

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@cvsloane, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 45 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ff75528a-c9c2-4b27-9b69-31c73e608e4f

📥 Commits

Reviewing files that changed from the base of the PR and between 772218c and e3f2295.

📒 Files selected for processing (5)
  • apps/dashboard/src/app/(dashboard)/settings/UsageOverview.tsx
  • apps/dashboard/src/components/layout/SidebarNav.tsx
  • apps/dashboard/src/components/tmux/windowActions.test.ts
  • apps/dashboard/src/components/tmux/windowActions.ts
  • tasks/2026-07-20-fw4-fleet-brief.md
📝 Walkthrough

Walkthrough

The dashboard is reorganized around a root Command Center with unified navigation, attention, and launch surfaces. TMUX gains canonical routing, topology-backed workspace controls, quick switching, pane actions, and paged scrollback history, with expanded unit, contract, and smoke coverage.

Changes

Command Center shell and attention

Layer / File(s) Summary
Root shell, navigation, and attention surfaces
apps/dashboard/src/app/(dashboard)/page.tsx, apps/dashboard/src/app/(dashboard)/orchestrator/*, apps/dashboard/src/components/layout/*, apps/dashboard/src/components/orchestrator/*
The root route renders the Command Center, navigation targets / and /orchestrator?tab=attention, and attention rendering is consolidated into OrchestratorSurface with page and sheet presentations.
Canonical tmux routing
apps/dashboard/src/app/(dashboard)/tmux/page.tsx, apps/dashboard/src/hooks/useTmuxRosterData.ts, apps/dashboard/src/components/orchestrator/*, apps/dashboard/src/components/layout/RecentSessions.tsx, apps/dashboard/public/manifest.json
The /tmux page redirects to / while preserving query parameters, and terminal links and the PWA manifest use / as the canonical entry route.
Unified launch flow
apps/dashboard/src/components/launch/*, apps/dashboard/src/app/(dashboard)/sessions/SessionsPageClient.tsx, apps/dashboard/src/components/session-generator/*
Command Center and Sessions use LaunchRail and MobileLaunchSheet, with centralized provider definitions, recent-launch persistence, and recent repository selection.

TMUX workspace and terminal controls

Layer / File(s) Summary
Topology-backed workspace
apps/dashboard/src/stores/tmuxTopology.ts, apps/dashboard/src/hooks/useTmuxTopology.ts, apps/dashboard/src/components/tmux/TmuxTerminalWorkspace.tsx, apps/dashboard/src/components/tmux/TmuxWindowStrip.tsx
Roster and live topology data populate per-host topology state, window strips support optimistic actions, and desktop workspaces can retain a secondary terminal.
Pane controls and quick switching
apps/dashboard/src/components/tmux/TmuxPaneControls.tsx, apps/dashboard/src/components/tmux/TmuxQuickSwitchStrip.tsx, apps/dashboard/src/components/tmux/paneActions.ts, apps/dashboard/src/components/tmux/windowActions.ts, apps/dashboard/src/components/tmux/TmuxKeyBar.tsx
TMUX controls support splitting, zooming, pane selection, pane termination, window actions, capability-gated percentage splits, collapsible key bars, and recent-pane switching.
Scrollback history
apps/dashboard/src/lib/api.ts, apps/dashboard/src/components/terminal/ScrollbackPager.tsx, apps/dashboard/src/components/terminal/scrollbackPaging.ts, apps/dashboard/src/components/tmux/TmuxActionSheet.tsx
A range-based scrollback API and pager provide older-page loading, filtering, virtualization, copying, retry states, and history access from pane controls.

Validation and supporting records

Layer / File(s) Summary
Contract and behavior tests
apps/dashboard/src/components/layout/*.test.ts, apps/dashboard/src/components/launch/definitions.test.ts, apps/dashboard/src/components/terminal/scrollbackPaging.test.ts, apps/dashboard/src/components/tmux/*.test.ts, apps/dashboard/src/hooks/useTmuxRosterData.test.ts, apps/dashboard/src/stores/tmuxTopology.test.ts
Tests cover shell contracts, launch definitions, canonical routing, scrollback ranges, pane and window actions, quick switching, and topology fallback/staleness behavior.
Dashboard smoke coverage and workstream records
tests/smoke/dashboard.spec.ts, tasks/**/*.md, tasks/**/*.jsonl
Smoke tests cover Command Center viewports, launch and attention flows, redirects, roster request counts, mobile terminal actions, and scrollback history; task and handoff records document Wave 3 and Wave 4 workstreams.

Estimated code review effort: 5 (Critical) | ~120 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 1.75% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main changes: Command Center landing and in-app tmux management for Wave 3.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/frontend-command-center

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 5

🧹 Nitpick comments (6)
apps/dashboard/src/components/orchestrator/OrchestratorSurface.tsx (1)

81-83: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick win

Guard refreshAll/refresh against rejected promises.

refreshAll (lines 81-83) has no .catch, and it's invoked as a fire-and-forget void refreshAll() at Line 117 and Line 245; void refresh() at Line 186/216 has the same shape. If refresh() or fleet.refresh() ever rejects, this surfaces as an unhandled promise rejection instead of being reflected in allErrors/UI state.

♻️ Suggested guard
   const refreshAll = async () => {
-    await Promise.all([refresh(), fleet.refresh()]);
+    await Promise.all([refresh(), fleet.refresh()]).catch((error) => {
+      console.error('Failed to refresh attention/fleet data', error);
+    });
   };

Also applies to: 117-117, 186-186, 216-216, 245-245

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@apps/dashboard/src/components/orchestrator/OrchestratorSurface.tsx` around
lines 81 - 83, Guard the asynchronous refresh flows in OrchestratorSurface:
update refreshAll to catch rejections from refresh or fleet.refresh, and add
equivalent rejection handling to the fire-and-forget refreshAll and refresh
invocations. Route caught errors through the existing allErrors/UI error-state
mechanism so no rejected refresh promise becomes unhandled.
apps/dashboard/src/components/tmux/TmuxTerminalWorkspace.tsx (1)

64-64: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Use the shared breakpoint constant instead of a literal.

useIsMobile(1024) duplicates COMMAND_CENTER_SHELL_BREAKPOINT (now exported from useIsMobile.ts and already adopted in TmuxPageClient.tsx). Keeping a raw literal here risks silent drift if the breakpoint is tuned later.

♻️ Proposed fix
-import { useHydrated } from '`@/hooks/useHydrated`';
-import { useIsMobile } from '`@/hooks/useIsMobile`';
+import { useHydrated } from '`@/hooks/useHydrated`';
+import { COMMAND_CENTER_SHELL_BREAKPOINT, useIsMobile } from '`@/hooks/useIsMobile`';
...
-  const belowDesktop = useIsMobile(1024);
+  const belowDesktop = useIsMobile(COMMAND_CENTER_SHELL_BREAKPOINT);
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@apps/dashboard/src/components/tmux/TmuxTerminalWorkspace.tsx` at line 64,
Update the belowDesktop initialization in TmuxTerminalWorkspace to pass the
shared COMMAND_CENTER_SHELL_BREAKPOINT constant to useIsMobile instead of the
literal 1024, reusing the exported breakpoint already used by TmuxPageClient.
apps/dashboard/src/components/tmux/TmuxWindowStrip.tsx (1)

187-277: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Loop/IIFE variable window shadows the global window object.

Currently handled safely (line 242 explicitly uses globalThis.window.setTimeout to dodge the shadow), but the shadowing itself is a footgun for future edits inside these blocks — any added bare window.confirm/window.open call would silently resolve to the tmux window object instead of the global.

♻️ Proposed rename
-        {windows.map((window) => {
-          const editing = editingWindowIndex === window.windowIndex;
+        {windows.map((tmuxWindow) => {
+          const editing = editingWindowIndex === tmuxWindow.windowIndex;
   ...
-          const window = windows.find((candidate) => candidate.windowIndex === contextWindowIndex);
-          if (!window) return null;
+          const activeWindow = windows.find((candidate) => candidate.windowIndex === contextWindowIndex);
+          if (!activeWindow) return null;

(rename all references inside the callback bodies accordingly)

Also applies to: 291-297

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@apps/dashboard/src/components/tmux/TmuxWindowStrip.tsx` around lines 187 -
277, Rename the `windows.map` callback variable `window` to a non-conflicting
name such as `tmuxWindow`, and update all references within the mapped JSX and
event handlers, including the related block around the additional usage at lines
291-297. Preserve the existing behavior and keying while eliminating shadowing
of the global `window` object.
apps/dashboard/src/components/tmux/TmuxPaneControls.tsx (1)

200-242: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Directional pane buttons collapse into two actions. Up/Left both target previousPane and Down/Right both target nextPane, and each pair enables/disables together — so the four arrows only ever perform two navigations over a flat pane list. This can mislead users expecting spatial (2D) pane movement. If tmux directional selection is available, consider dispatching direction-based select_pane (e.g. -L/-R/-U/-D) instead of index±1; otherwise reducing to two buttons (prev/next) would make the behavior clearer.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@apps/dashboard/src/components/tmux/TmuxPaneControls.tsx` around lines 200 -
242, The directional controls currently map Up/Left to previousPane and
Down/Right to nextPane, exposing four misleading buttons for two actions. Update
the sheet controls in TmuxPaneControls to dispatch true direction-based tmux
pane selection for left, right, up, and down when supported; otherwise replace
the four arrows with clearly labeled previous/next controls and preserve the
existing pendingAction and availability handling.
apps/dashboard/src/components/orchestrator/OrchestratorButton.tsx (1)

33-33: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Duplicated attention-status list across two files. Both files independently define the identical 'RUNNING,STARTING,WAITING_FOR_INPUT,WAITING_FOR_APPROVAL,ERROR,IDLE' status string with no shared source of truth, risking future drift between the badge-count logic and the settings-stats logic.

  • apps/dashboard/src/components/orchestrator/OrchestratorButton.tsx#L33-L33: extract this into a shared constant (e.g. in stores/orchestrator.ts or a shared constants module) and import it here.
  • apps/dashboard/src/app/(dashboard)/settings/UsageOverview.tsx#L11-L11: import the same shared constant instead of redefining WORKFLOW_STATUSES.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@apps/dashboard/src/components/orchestrator/OrchestratorButton.tsx` at line
33, Extract the duplicated attention-status string into one shared exported
constant, preferably near the orchestrator store or shared constants. Update
apps/dashboard/src/components/orchestrator/OrchestratorButton.tsx lines 33-33 to
import and use it, and update
apps/dashboard/src/app/(dashboard)/settings/UsageOverview.tsx lines 11-11 to
import the same constant instead of redefining WORKFLOW_STATUSES.
apps/dashboard/src/components/launch/definitions.ts (1)

20-23: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick win

Two independent copies of the mobile-provider set can drift from the MobileLaunchProvider schema union. Both sites hand-track which providers are mobile-capable rather than deriving from a single source of truth, so a change to the MobileLaunchProvider union would silently break mobile launch/restore with no compile-time signal.

  • apps/dashboard/src/components/launch/definitions.ts#L20-L23: replace the .mobile-flag filter + id is MobileLaunchProvider cast with a filter keyed off the actual MobileLaunchProvider union (e.g. a Set of union members) so the type predicate is sound and the set stays complete.
  • apps/dashboard/src/components/launch/recentLaunchStore.ts#L22-L28: replace the literal 'codex'/'claude_code' check with validation against the same shared union (e.g. reuse MOBILE_LAUNCH_PROVIDERS/schema parse) so persisted launches for future providers aren't discarded.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@apps/dashboard/src/components/launch/definitions.ts` around lines 20 - 23,
The mobile-provider lists are independently hand-maintained and can diverge from
the MobileLaunchProvider union. In
apps/dashboard/src/components/launch/definitions.ts#L20-L23, replace the mobile
flag filter and cast with membership validation derived from the actual
MobileLaunchProvider union, using a shared set or equivalent sound type guard;
in apps/dashboard/src/components/launch/recentLaunchStore.ts#L22-L28, reuse that
shared provider validation or schema instead of checking only 'codex' and
'claude_code', so future union members are preserved.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@apps/dashboard/src/app/`(dashboard)/settings/UsageOverview.tsx:
- Around line 53-58: Update the session bucket calculations in the UsageOverview
memo so active sessions exclude any session marked idle via idled_at, reusing
the existing isIdle predicate if available. Keep attention unchanged and ensure
each session is counted in only one bucket.

In `@apps/dashboard/src/components/layout/SidebarNav.tsx`:
- Around line 82-88: Update the isActive helper to avoid partial route matches
by returning true only when pathname exactly equals path or begins with path
followed by a slash. Preserve the special root-path handling and query-string
stripping, matching the route behavior used by MobileBottomNav.

In `@apps/dashboard/src/components/tmux/TmuxTerminalWorkspace.tsx`:
- Around line 144-150: Update the secondary terminal rendering in
TmuxTerminalWorkspace to use PersistentTerminalSlot instead of mounting
TerminalView directly, passing the secondary session and pane identifiers plus
its controller and attachment state. Preserve the existing split behavior while
ensuring the secondary terminal remains on the persistent host across closing
and switching.

In `@apps/dashboard/src/components/tmux/windowActions.ts`:
- Around line 40-58: Update the close confirmation logic in runTmuxWindowAction
so topology-sourced windows always require confirmation: retain the
session-ending warning when windowCount is 1, and use the standard “Close this
window?” confirmation when windowCount is greater than 1, matching the roster
path.

In `@apps/dashboard/src/stores/tmuxTopology.ts`:
- Around line 198-254: Update the live topology handling around setRoster and
liveSnapshotIsFresh so expired live snapshots are removed automatically rather
than only during roster updates. Add a timer-based expiration path for each host
that clears liveByHost and rebuilds the host from its roster when the snapshot
becomes stale, while preserving fresh live views and avoiding timers for absent
or already-expired snapshots.

---

Nitpick comments:
In `@apps/dashboard/src/components/launch/definitions.ts`:
- Around line 20-23: The mobile-provider lists are independently hand-maintained
and can diverge from the MobileLaunchProvider union. In
apps/dashboard/src/components/launch/definitions.ts#L20-L23, replace the mobile
flag filter and cast with membership validation derived from the actual
MobileLaunchProvider union, using a shared set or equivalent sound type guard;
in apps/dashboard/src/components/launch/recentLaunchStore.ts#L22-L28, reuse that
shared provider validation or schema instead of checking only 'codex' and
'claude_code', so future union members are preserved.

In `@apps/dashboard/src/components/orchestrator/OrchestratorButton.tsx`:
- Line 33: Extract the duplicated attention-status string into one shared
exported constant, preferably near the orchestrator store or shared constants.
Update apps/dashboard/src/components/orchestrator/OrchestratorButton.tsx lines
33-33 to import and use it, and update
apps/dashboard/src/app/(dashboard)/settings/UsageOverview.tsx lines 11-11 to
import the same constant instead of redefining WORKFLOW_STATUSES.

In `@apps/dashboard/src/components/orchestrator/OrchestratorSurface.tsx`:
- Around line 81-83: Guard the asynchronous refresh flows in
OrchestratorSurface: update refreshAll to catch rejections from refresh or
fleet.refresh, and add equivalent rejection handling to the fire-and-forget
refreshAll and refresh invocations. Route caught errors through the existing
allErrors/UI error-state mechanism so no rejected refresh promise becomes
unhandled.

In `@apps/dashboard/src/components/tmux/TmuxPaneControls.tsx`:
- Around line 200-242: The directional controls currently map Up/Left to
previousPane and Down/Right to nextPane, exposing four misleading buttons for
two actions. Update the sheet controls in TmuxPaneControls to dispatch true
direction-based tmux pane selection for left, right, up, and down when
supported; otherwise replace the four arrows with clearly labeled previous/next
controls and preserve the existing pendingAction and availability handling.

In `@apps/dashboard/src/components/tmux/TmuxTerminalWorkspace.tsx`:
- Line 64: Update the belowDesktop initialization in TmuxTerminalWorkspace to
pass the shared COMMAND_CENTER_SHELL_BREAKPOINT constant to useIsMobile instead
of the literal 1024, reusing the exported breakpoint already used by
TmuxPageClient.

In `@apps/dashboard/src/components/tmux/TmuxWindowStrip.tsx`:
- Around line 187-277: Rename the `windows.map` callback variable `window` to a
non-conflicting name such as `tmuxWindow`, and update all references within the
mapped JSX and event handlers, including the related block around the additional
usage at lines 291-297. Preserve the existing behavior and keying while
eliminating shadowing of the global `window` object.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1a7ac852-b042-4211-aede-fda569b22729

📥 Commits

Reviewing files that changed from the base of the PR and between effab04 and 772218c.

📒 Files selected for processing (77)
  • apps/dashboard/public/manifest.json
  • apps/dashboard/src/app/(dashboard)/layout.tsx
  • apps/dashboard/src/app/(dashboard)/orchestrator/OrchestratorPageClient.tsx
  • apps/dashboard/src/app/(dashboard)/orchestrator/page.tsx
  • apps/dashboard/src/app/(dashboard)/page.tsx
  • apps/dashboard/src/app/(dashboard)/sessions/SessionsPageClient.tsx
  • apps/dashboard/src/app/(dashboard)/settings/UsageOverview.tsx
  • apps/dashboard/src/app/(dashboard)/settings/page.tsx
  • apps/dashboard/src/app/(dashboard)/tmux/TmuxPageClient.tsx
  • apps/dashboard/src/app/(dashboard)/tmux/page.tsx
  • apps/dashboard/src/components/SpawnSessionDialog.tsx
  • apps/dashboard/src/components/automation/AutomationAgentCard.tsx
  • apps/dashboard/src/components/launch/LaunchRail.tsx
  • apps/dashboard/src/components/launch/MobileLaunchSheet.tsx
  • apps/dashboard/src/components/launch/definitions.test.ts
  • apps/dashboard/src/components/launch/definitions.ts
  • apps/dashboard/src/components/launch/recentLaunchStore.ts
  • apps/dashboard/src/components/layout/AttentionSettings.tsx
  • apps/dashboard/src/components/layout/AttentionSummary.tsx
  • apps/dashboard/src/components/layout/GlobalSidebar.tsx
  • apps/dashboard/src/components/layout/HeaderConnectionStatus.tsx
  • apps/dashboard/src/components/layout/MobileBottomNav.tsx
  • apps/dashboard/src/components/layout/MobileHeader.tsx
  • apps/dashboard/src/components/layout/QuickSpawn.tsx
  • apps/dashboard/src/components/layout/RecentSessions.tsx
  • apps/dashboard/src/components/layout/SidebarNav.tsx
  • apps/dashboard/src/components/layout/index.ts
  • apps/dashboard/src/components/layout/shellContracts.test.ts
  • apps/dashboard/src/components/orchestrator/OrchestratorButton.tsx
  • apps/dashboard/src/components/orchestrator/OrchestratorFleetCard.tsx
  • apps/dashboard/src/components/orchestrator/OrchestratorItem.tsx
  • apps/dashboard/src/components/orchestrator/OrchestratorModal.tsx
  • apps/dashboard/src/components/orchestrator/OrchestratorSurface.tsx
  • apps/dashboard/src/components/orchestrator/index.ts
  • apps/dashboard/src/components/session-generator/RepoPicker.tsx
  • apps/dashboard/src/components/session-generator/SessionConfigStep.tsx
  • apps/dashboard/src/components/session-generator/index.ts
  • apps/dashboard/src/components/session/SessionWorkbench.tsx
  • apps/dashboard/src/components/settings/SettingsButton.tsx
  • apps/dashboard/src/components/settings/index.ts
  • apps/dashboard/src/components/terminal/ScrollbackPager.tsx
  • apps/dashboard/src/components/terminal/TerminalSurface.tsx
  • apps/dashboard/src/components/terminal/scrollbackPaging.test.ts
  • apps/dashboard/src/components/terminal/scrollbackPaging.ts
  • apps/dashboard/src/components/tmux/TmuxActionSheet.tsx
  • apps/dashboard/src/components/tmux/TmuxKeyBar.tsx
  • apps/dashboard/src/components/tmux/TmuxMobileShell.tsx
  • apps/dashboard/src/components/tmux/TmuxPaneControls.tsx
  • apps/dashboard/src/components/tmux/TmuxQuickSwitchStrip.tsx
  • apps/dashboard/src/components/tmux/TmuxTerminalWorkspace.tsx
  • apps/dashboard/src/components/tmux/TmuxWindowStrip.tsx
  • apps/dashboard/src/components/tmux/paneActions.test.ts
  • apps/dashboard/src/components/tmux/paneActions.ts
  • apps/dashboard/src/components/tmux/quickSwitch.test.ts
  • apps/dashboard/src/components/tmux/quickSwitch.ts
  • apps/dashboard/src/components/tmux/windowActions.test.ts
  • apps/dashboard/src/components/tmux/windowActions.ts
  • apps/dashboard/src/hooks/useIsMobile.ts
  • apps/dashboard/src/hooks/useTmuxRosterData.test.ts
  • apps/dashboard/src/hooks/useTmuxRosterData.ts
  • apps/dashboard/src/hooks/useTmuxTopology.ts
  • apps/dashboard/src/lib/api.ts
  • apps/dashboard/src/stores/settings.ts
  • apps/dashboard/src/stores/tmuxTopology.test.ts
  • apps/dashboard/src/stores/tmuxTopology.ts
  • apps/dashboard/src/stores/ui.ts
  • tasks/2026-07-20-fw3-shell-brief.md
  • tasks/2026-07-20-fw3-tmux-ui-brief.md
  • tasks/2026-07-20-fw3-tmux-ui-corrections-brief.md
  • tasks/2026-07-20-fw4-fleet-brief.md
  • tasks/2026-07-20-fw4-surfaces-brief.md
  • tasks/frontend-ux-handoffs/fw3-shell.md
  • tasks/frontend-ux-handoffs/fw3-tmux-ui.md
  • tasks/frontend-ux-log.md
  • tasks/frontend-ux-metrics.jsonl
  • tasks/lessons.md
  • tests/smoke/dashboard.spec.ts
💤 Files with no reviewable changes (7)
  • apps/dashboard/src/components/SpawnSessionDialog.tsx
  • apps/dashboard/src/app/(dashboard)/orchestrator/OrchestratorPageClient.tsx
  • apps/dashboard/src/components/settings/SettingsButton.tsx
  • apps/dashboard/src/components/layout/MobileHeader.tsx
  • apps/dashboard/src/components/orchestrator/OrchestratorModal.tsx
  • apps/dashboard/src/components/settings/index.ts
  • apps/dashboard/src/stores/ui.ts

cvsloane and others added 2 commits July 20, 2026 14:45
… nav matching, confirm on every topology window close

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@cvsloane

Copy link
Copy Markdown
Owner Author

Review threads: (1) idle/active buckets now mutually exclusive (2d64726); (2) nav active-state uses exact/boundary matching (2d64726); (3) secondary terminal is intentionally ephemeral — the persistent-host budget is 1 background terminal by locked design; both visible terminals are foreground and the ephemeral slot cleans up its WS on unmount (verified in adversarial review); (4) every topology-mode window close now confirms, matching native tmux confirm-before (2d64726); (5) stale live-topology snapshots clear on the roster feed cadence today; a timer-based fallback is scoped into the Wave-4 fleet data-flow rework (brief updated).

@cvsloane
cvsloane merged commit f3df15d into main Jul 20, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant