Skip to content

Ensure sponsor logos use light background#26

Merged
gatheluck merged 3 commits into
developfrom
fix-sponsor-card-bg
Oct 21, 2025
Merged

Ensure sponsor logos use light background#26
gatheluck merged 3 commits into
developfrom
fix-sponsor-card-bg

Conversation

@gatheluck

Copy link
Copy Markdown
Contributor

Summary

  • keep sponsor logo container background white in both themes to avoid darkening logos

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

FOUND/src/app/routes.ts

Lines 8 to 18 in af50a0a

export default [
layout("./layout.tsx", [
index("./routes/Home.tsx"),
// route("/call-for-papers", "./routes/CallForPapers.tsx"),
// route("/schedule", "./routes/Schedule.tsx"),
route("/program", "./routes/Program.tsx"),
route("/organizers", "./routes/Organizers.tsx"),
route("/sponsorship", "./routes/Sponsorship.tsx"),
// route("/past-events", "./routes/PastEvents.tsx"),
route("/contact", "./routes/Contact.tsx"),
]),

P1 Badge Sponsors page is never registered in the router

The commit creates a dedicated Sponsors route component but the central router configuration still only exposes /program, /organizers, /sponsorship, and /contact. Without adding /sponsors here, the new component is never imported or rendered, so the intended white background for logos never affects the application and the page is unreachable.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

Comment on lines +4 to +7
import { Button } from "../../components/ui/button";
import { Card, CardContent, CardFooter } from "../../components/ui/card";
import sponsorsData from "../../data/sponsors.json";

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0 Badge Import sponsors data file that doesn’t exist

The new Sponsors route imports ../../data/sponsors.json, but that file isn’t present anywhere in the repository. As soon as this component is wired into the router, the build will fail with a module‑not‑found error and the page cannot render. Either add the JSON file or reuse existing data before enabling the route.

Useful? React with 👍 / 👎.

@gatheluck gatheluck self-assigned this Oct 10, 2025
@gatheluck
gatheluck merged commit 17d0817 into develop Oct 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant