Adding Todo Entities (v2) - #354
Closed
iamkarlson wants to merge 17 commits into
Closed
Conversation
Ongoing addition for update support Delete support should theoretically work, but am running into issues with pygrocy
; Conflicts: ; custom_components/grocy/config_flow.py ; custom_components/grocy/coordinator.py ; custom_components/grocy/grocy_data.py ; custom_components/grocy/services.py
Contributor
Author
|
@isabellaalstrom you mentioned in the original PR that it can be merged if conflicts would be resolved, now they are |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found this PR to be quite useful but it's long overdue to merge upstream and author didn't comeback with changes to resolve conflicts. This PR just adds merging master back and porting changes related to migration to pygrocy2.
Also, to test these changes I have to refresh devcontainer setup and instead of reviving the old one, I simply picked this one as it looks battletested.
I tested Chores and Tasks functionality manually with my Grocy instance ( HA setup and change data).